From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162316-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 123682 invoked by alias); 16 Dec 2019 21:09:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 123673 invoked by uid 89); 16 Dec 2019 21:09:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=forgotten
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2019 21:09:37 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id B88D71169DC;	Mon, 16 Dec 2019 16:09:35 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id mAnG55K5lCo6; Mon, 16 Dec 2019 16:09:35 -0500 (EST)
Received: from murgatroyd (75-166-123-50.hlrn.qwest.net [75.166.123.50])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by rock.gnat.com (Postfix) with ESMTPSA id 5C0051166EE;	Mon, 16 Dec 2019 16:09:35 -0500 (EST)
From: Tom Tromey <tromey@adacore.com>
To: Christian Biesinger <cbiesinger@google.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Constify get_exec_file
References: <20191213221108.8948-1-tromey@adacore.com>	<CAPTJ0XE1M92ZwX4aL5grhJH-p7o-b7Ax2aXkLshaJZ3_Di_EFw@mail.gmail.com>
Date: Mon, 16 Dec 2019 21:09:00 -0000
In-Reply-To: <CAPTJ0XE1M92ZwX4aL5grhJH-p7o-b7Ax2aXkLshaJZ3_Di_EFw@mail.gmail.com>	(Christian Biesinger's message of "Fri, 13 Dec 2019 17:13:54 -0500")
Message-ID: <874ky0t1td.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-12/txt/msg00724.txt.bz2

>>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:

Christian> Maybe use const_cast<char*> for those to make the intent clearer?

Good idea.  I'm did this and I'm going to check it in.

I also found that I had forgotten to remove a couple of casts to "char *".
I've removed those as well.

Tom