From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60710 invoked by alias); 7 Jan 2020 19:38:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60702 invoked by uid 89); 7 Jan 2020 19:38:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 19:38:50 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 2757024ED for ; Tue, 7 Jan 2020 13:38:49 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ougjiKaLjqNtvougjixzqd; Tue, 07 Jan 2020 13:38:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RcnsQRgOcOT/tjxsTvhIW04z6Z/fGH4LkIoxxwZK7MQ=; b=sXF4fbpoXFlq5822xqstPENSF8 H2WSLBdb25SfQgmAjBCLi7ROppo4Sk+49s/RbXD2Uxj95PP9aAR4gMt4H6FLRstmt18VyJklqUVra k12QF9oYovQTTPebcpCAzAUdW; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38308 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iougi-001ltG-TV; Tue, 07 Jan 2020 12:38:48 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey , Hannes Domani Subject: Re: [PATCH 0/6] Vertical scrolling and another small bug fix References: <874kxrc3ha.fsf@tromey.com> Date: Tue, 07 Jan 2020 19:38:00 -0000 In-Reply-To: (Andrew Burgess's message of "Tue, 7 Jan 2020 11:52:13 +0000") Message-ID: <874kx7f453.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00160.txt.bz2 Andrew> This is a different (simpler) approach than I originally suggested. I meant to reply to that one. I thought the changes in tui-hooks.c looked reasonable. If you want to resurrect that, I'm in favor of it. Andrew> I'm still not really happy with how the tui keeps track and displays Andrew> the current symtab_and_line Me too. Andrew> However, I think leaving the ability to vertically scroll broken isn't Andrew> good, and I think this series is a step in the right direction Andrew> (maybe?). Agreed. It all looks good to me. Tom