From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106283 invoked by alias); 17 Jan 2020 20:56:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106275 invoked by uid 89); 17 Jan 2020 20:56:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=201411, 2014-11 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 20:56:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B9139117804; Fri, 17 Jan 2020 15:55:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cQcglNoj+A8A; Fri, 17 Jan 2020 15:55:58 -0500 (EST) Received: from murgatroyd (75-166-123-50.hlrn.qwest.net [75.166.123.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 41D3B11776C; Fri, 17 Jan 2020 15:55:58 -0500 (EST) From: Tom Tromey To: Tom Tromey Cc: Eli Zaretskii , Christian Biesinger , palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> <83d0bi348d.fsf@gnu.org> <871rrygco6.fsf@tromey.com> Date: Fri, 17 Jan 2020 21:03:00 -0000 In-Reply-To: <871rrygco6.fsf@tromey.com> (Tom Tromey's message of "Fri, 17 Jan 2020 11:28:41 -0700") Message-ID: <874kwteraa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00568.txt.bz2 >>>>> "Tom" == Tom Tromey writes: >>>>> "Eli" == Eli Zaretskii writes: Eli> I wonder whether a better way is not to import the Gnulib 'stat' and Eli> 'fstat' modules at all. Are they required by other Gnulib modules, Eli> and if so, by which ones? Tom> I am wondering this as well. While I think we can track down the bad Tom> spots -- either calling the "wrong" stat or incorrectly comparing values Tom> from the different stats (the patches I sent probably accomplish the Tom> latter already) -- it seems fragile to rely on this. It came in originally in a patch I sent and one that Yao sent: https://sourceware.org/ml/gdb-patches/2013-11/msg00502.html https://sourceware.org/ml/gdb-patches/2014-11/msg00654.html I thought maybe removing these workarounds would be ok, but it seems like it can't be done: when I remove stat and lstat from update-gnulib.sh, they still appear. Maybe --avoid=stat will work. Tom