Re: [PATCH 1/2] gdbsupport: rename source files to .cc

Pedro Alves
2020-02-13T18:34:09Z

On 2/13/20 2:04 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> This patch renames the .c source files in gdbsupport to .cc.
>
> I support this change.
>
> Note that this would let us remove these hacks from gdbsupport/Makefile.am:
>
> override CXX += $(CXX_DIALECT)
>
> override CC := $(CXX)
> override CFLAGS := $(CXXFLAGS)
>
> AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
>
>
> The CC and CFLAGS settings can be removed entirely. AM_CFLAGS can be
> renamed to AM_CXXFLAGS, and the CXX_DIALECT can be put there.

I had preferred overriding CXX instead of CXXFLAGS for the reasons
explained at [1] [2]. Sounds like that defeats it.

[1] https://sourceware.org/ml/gdb-patches/2020-01/msg00453.html
[2] https://sourceware.org/ml/gdb-patches/2020-01/msg00460.html

Thanks,
Pedro Alves