Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org,  Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH][gdb] Fix missing symtab includes
Date: Sat, 28 Mar 2020 13:08:33 -0600	[thread overview]
Message-ID: <874ku8z49a.fsf@tromey.com> (raw)
In-Reply-To: <20200327204948.GA23365@delia> (Tom de Vries's message of "Fri, 27 Mar 2020 21:49:50 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Thanks for the analysis.  This is very helpful.

Tom> - the hello.c partial symtab is expanded using dwarf2_psymtab::expand_psymtab
Tom> - process_cu_includes is never called

It seems to me that perhaps the call to process_cu_includes is
misplaced.  Why is it where it is and not elsewhere?

I guess the idea is that it should be called after a group of CUs have
been processed.  So maybe your patch is the correct way.  But it seems
like it would be worth understanding this a bit better and perhaps
sticking a comment somewhere explaining the approach.

Tom


      parent reply	other threads:[~2020-03-28 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 20:49 Tom de Vries
2020-03-28 16:32 ` Simon Marchi
2020-03-28 17:24   ` Tom de Vries
2020-03-29 15:39     ` Simon Marchi
2020-03-29 15:56       ` Tom de Vries
2020-03-29 21:44         ` Simon Marchi
2020-03-30 17:42           ` Tom de Vries
2020-04-14 13:31             ` Tom de Vries
2020-03-28 19:08 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ku8z49a.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox