From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yBnbM7sZml8bdwAAWB0awg (envelope-from ) for ; Wed, 28 Oct 2020 21:24:11 -0400 Received: by simark.ca (Postfix, from userid 112) id D22271EFC1; Wed, 28 Oct 2020 21:24:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83EC91E552 for ; Wed, 28 Oct 2020 21:24:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E9C4396E071; Thu, 29 Oct 2020 01:24:11 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.239]) by sourceware.org (Postfix) with ESMTPS id 7D4DD386EC0B for ; Thu, 29 Oct 2020 01:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7D4DD386EC0B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 0448210CF4 for ; Wed, 28 Oct 2020 20:24:08 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id XwffkiSu2mi4BXwffktuZJ; Wed, 28 Oct 2020 20:24:08 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RP6dL3Q0COAmis5sdWUNWYdIbr88iWSsMBTdTtWEVoM=; b=GdW1XS9EjfU5etCUGWS7/e9diM 7gplIfJkYcm5I2JQS/Cg5ArJpCKpP85sVfzU66mEHYWZPSpaFFP+KsSa0iwX6zEyVvFEqAoFp4YJR JZCp4HD9Df9jQ5atu7SVQcgpF; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:58178 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kXwff-0013yS-Oy; Wed, 28 Oct 2020 19:24:07 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PP?] [PATCH v2 12/16] Change remove_target_sections to method on program_space References: <20201019214429.13815-1-tom@tromey.com> <20201019214429.13815-13-tom@tromey.com> <64804345-db3f-d562-6e82-137fb577df41@simark.ca> X-Attribution: Tom Date: Wed, 28 Oct 2020 19:24:06 -0600 In-Reply-To: <64804345-db3f-d562-6e82-137fb577df41@simark.ca> (Simon Marchi's message of "Tue, 20 Oct 2020 10:40:49 -0400") Message-ID: <874kmdakp5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kXwff-0013yS-Oy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (bapiya) [97.122.89.243]:58178 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: >> void >> -remove_target_sections (void *owner) >> +program_space::remove_target_sections (void *owner) Simon> Would it make sense to make a subsequent patch that just moves this Simon> method to progspace.c? I think it's ok to leave it in exec.c in this Simon> patch, so we can more easily see the diff, but I think in the end it Simon> belongs to progspace.c. Yeah, makes sense to me. Simon> The only thing that doesn't belong to progspace.c in this method is: Simon> unpush_target (&exec_ops); Simon> But I think it just means that we need better decoupling. We could have Simon> a "program_space_target_sections_changed" observer, which exec.c would Simon> attach to, and push/unpush as necessary. I am not totally sure. Sometimes observers make the code more obscure. >> - if (inf->pspace != curr_pspace) >> + if (inf->pspace != this) >> continue; >> >> if (!inf->pspace->target_sections.empty ()) Simon> This line can be simplified, I believe: Simon> if (!this->target_sections.empty ()) Simon> (you can omit `this` to be consistent with the rest of the code, I just Simon> happen to like using `this` to access fields that aren't prefixed with Simon> `m_`, for clarity) Thanks for pointing this out. I think the entire 'if' can be removed, because we already know from an outer 'if' that target_sections is empty. Tom