From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lTONOL/1P2A0YQAAWB0awg (envelope-from ) for ; Wed, 03 Mar 2021 15:46:55 -0500 Received: by simark.ca (Postfix, from userid 112) id D896E1EF78; Wed, 3 Mar 2021 15:46:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 88D851E54D for ; Wed, 3 Mar 2021 15:46:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F33E384B80F; Wed, 3 Mar 2021 20:46:55 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.109]) by sourceware.org (Postfix) with ESMTPS id 2D1A9386F011 for ; Wed, 3 Mar 2021 20:46:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2D1A9386F011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 0C8B22EBFF for ; Wed, 3 Mar 2021 14:46:40 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HYOFlk8vWA1KVHYOGlB45S; Wed, 03 Mar 2021 14:46:40 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z2NuETY5NkVrfqN6O8jD+F+9rpCCKnF8dxBK7v3uiJs=; b=vygYl0juwSdfvLSXJEJq8qgD/Q 9xv0WyIMaB/dWM1AqZU1MJM9yOt7B8l88ql11zXA7LQMieabWU085cf39ici+PHZIyE2poJaVorES yjstFPF/xwbYWQiik7fV7Qzwv; Received: from 71-211-165-100.hlrn.qwest.net ([71.211.165.100]:58090 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lHYOF-004L0I-NS; Wed, 03 Mar 2021 13:46:39 -0700 From: Tom Tromey To: Weimin Pan via Gdb-patches Subject: Re: [PATCH,V2 4/5] CTF: add all members of an enum type to psymtab References: <1614650018-9135-1-git-send-email-weimin.pan@oracle.com> <1614650018-9135-2-git-send-email-weimin.pan@oracle.com> <1614650018-9135-3-git-send-email-weimin.pan@oracle.com> <1614650018-9135-4-git-send-email-weimin.pan@oracle.com> <1614650018-9135-5-git-send-email-weimin.pan@oracle.com> X-Attribution: Tom Date: Wed, 03 Mar 2021 13:46:38 -0700 In-Reply-To: <1614650018-9135-5-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Mon, 1 Mar 2021 20:53:37 -0500") Message-ID: <874khsyngx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.165.100 X-Source-L: No X-Exim-ID: 1lHYOF-004L0I-NS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-165-100.hlrn.qwest.net (murgatroyd) [71.211.165.100]:58090 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Weimin Pan Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> ">" == Weimin Pan via Gdb-patches writes: >> With the following change which was made last April: >> [gdb] Use partial symbol table to find language for main >> commit d3214198119c1a2f9a6a2b8fcc56d8c324e1a245 >> The ctf reader was modified to enter all members of an enum type, >> similar to what the dwarf2 reader did, into the psymtab or gdb >> won't be able to find them. In addition, the empty name checking >> needed to be moved down so members of a unnamed enum were not left >> out. Thanks for the patch. >> + ctf_next_t *i = NULL; >> + >> + while ((ename = ctf_enum_next (ccp->fp, tid, &i, &val)) != NULL) Should probably use nullptr here. This is ok with this change. Tom