From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 89T3AgtxgWAxWgAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 08:50:19 -0400 Received: by simark.ca (Postfix, from userid 112) id F1A9A1F104; Thu, 22 Apr 2021 08:50:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EBE971E01F for ; Thu, 22 Apr 2021 08:50:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A43643896C18; Thu, 22 Apr 2021 12:50:17 +0000 (GMT) Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.61.9]) by sourceware.org (Postfix) with ESMTPS id 68ADB389443A for ; Thu, 22 Apr 2021 12:50:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68ADB389443A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 1D9194010AB73 for ; Thu, 22 Apr 2021 07:39:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZYmZlqNY9w11MZYmZlIz5m; Thu, 22 Apr 2021 07:50:11 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nMmA1T8mPHBU/h0IXJ8rnKb5V6E6o8PWS9fc6qmFX/I=; b=wZcrf54J4jaQVDV7bxVf98p5yp B9wG8W72jIet9+ZdLcfaMA3O4CDlsXHGEcmtYZD9uQHq4rOExK7KUwOKyqiBRxYhYQJZrg/TLWr09 /NIvEV5tJB7u3VM4N8GJ5Idyz; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:55830 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZYmZ-002Ieb-Io; Thu, 22 Apr 2021 06:50:11 -0600 From: Tom Tromey To: "Aktemur, Tankut Baris" Subject: Re: [PATCH 5/6] gdb/continuations: use lambdas instead of function pointers References: <4d9592aa18ca6528d300a4b77b8a552abdb7600d.1619009681.git.tankut.baris.aktemur@intel.com> <87sg3ja0eb.fsf@tromey.com> X-Attribution: Tom Date: Thu, 22 Apr 2021 06:50:10 -0600 In-Reply-To: (Tankut Baris Aktemur's message of "Thu, 22 Apr 2021 07:49:27 +0000") Message-ID: <874kfya3gd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lZYmZ-002Ieb-Io X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:55830 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> ">" == Aktemur, Tankut Baris writes: >> The continuations at the moment are rather plain, but just in case a >> continuation in the future adds more continuations, delaying the pop >> could cause a wrong element to be popped, I'm afraid. How about the >> following? (The same is to be used in Patch 6/6, too). >> @@ -122,7 +39,12 @@ void >> do_all_inferior_continuations () >> { >> struct inferior *inf = current_inferior (); >> - do_my_continuations (&inf->continuations); >> + while (!inf->continuations.empty ()) >> + { >> + auto iter = inf->continuations.begin (); >> + (*iter) (); >> + inf->continuations.erase (iter); It took me a minute to see what was going on here, at first I misread it a bit. But yeah, I see, I think this is fine. If elements are only ever added/popped from the front, maybe std::forward_list is preferable. >> Out of curiosity, how do you pronounce 'std'? I was just thinking if it >> should be "a std::function" or "an std::function". I pronounce std as >> "ess-tee-dee" and "an" sounded more natural to me. Hah, I didn't even think about that. In my head it sounds like "sted", but that's just something I made up myself. Either way is fine by me, or even just not referring to the type, since that's clear from context. Tom