From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MaIdFA9RAWLlOQAAWB0awg (envelope-from ) for ; Mon, 07 Feb 2022 12:04:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 42F421F3C6; Mon, 7 Feb 2022 12:04:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9709E1EE1A for ; Mon, 7 Feb 2022 12:04:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A222385840A for ; Mon, 7 Feb 2022 17:04:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A222385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644253453; bh=YG4jc3WYRtvpxgu0KplayvTeNLEeIEKdaL5NO2jTifU=; h=To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xMONxhEQXuCsZtyaREqcEzMZPWvIjWGHDcEYnoVn+ueuV6rfjl1dd4scaO3juaLyo +2BIFp1787oNcGrmHjkqy6qI5ZS/WcNCd9z3ihsylJvJwaln20VbMMvSjghAbji9Zb 2kYseAoY3KVi+z8+tr7n4eaIsXF2eYJx9nCRjnNc= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D1D893858C83 for ; Mon, 7 Feb 2022 17:03:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1D893858C83 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-cpZGQZFONu6PWCkt4A-1Uw-1; Mon, 07 Feb 2022 12:03:52 -0500 X-MC-Unique: cpZGQZFONu6PWCkt4A-1Uw-1 Received: by mail-wr1-f69.google.com with SMTP id c23-20020adfa317000000b001e320864b69so998890wrb.20 for ; Mon, 07 Feb 2022 09:03:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YG4jc3WYRtvpxgu0KplayvTeNLEeIEKdaL5NO2jTifU=; b=m6XAWi/u2JdpqFgWPDY1mM6+dGHGo/iEqsjai7IUrTFEA8Jc8wkIDM4mwTucMwO7NC A33I21hP9dcYh2bVVvVKuN+X7eM05xDfwvoa/iv+ch+DLmJsx4b+I9v2+pzEXjwjWuTJ 2KqbzbmSbUd+TnufNXa48MgfVB8bQK8LUlJdd+Tggyc3mYUfHSaG9m6E5Qu0niMRSuRR gid00gwOrqGiiQpmv41cEuxjYRlysMTfu2gzCV3ikYh9wZFWLBBqIs3NsJ7Pd1kn7zpG GS4+jH4M349AsU58gtWDU1MtYTvUY/g6Pd6Ls15DukGrcO21Bi7G5WGdXI0Z3/PTiA4Q er0w== X-Gm-Message-State: AOAM531QYwlfc3++6kV8uKC2Br7UmtjAOShg2bmMkzjis1NegO9WcBAD ysVbQDKDbSLAzI2LxDGcyvtKmJSzkybeyX1MXqbTfm1GRjxJ6BH6JNPCVUV1bMfOtIYgRNGSgv0 6YRPbNy7nSxgBqEnKFl1lxgNu+yjFKK27W2w4LLy8vKDuRXcTJWTBQZnGkyupbFif8q6T/YNumA == X-Received: by 2002:a05:600c:588:: with SMTP id o8mr288786wmd.103.1644253430539; Mon, 07 Feb 2022 09:03:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2fvSs+ydTliniUv3koCVr9zsZCMgiKLxLuC5t52CAAOFDRrdqdxWFn2eBXzkEB9a9+5HWmQ== X-Received: by 2002:a05:600c:588:: with SMTP id o8mr288763wmd.103.1644253430182; Mon, 07 Feb 2022 09:03:50 -0800 (PST) Received: from localhost (host86-134-151-224.range86-134.btcentralplus.com. [86.134.151.224]) by smtp.gmail.com with ESMTPSA id t1sm12675282wre.45.2022.02.07.09.03.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 09:03:49 -0800 (PST) To: gdb-patches@sourceware.org Cc: Subject: Re: [PATCH] gdb/python: allow Value.format_string to return styled output In-Reply-To: <83iltqyfk7.fsf@gnu.org> References: <20220125105005.333575-1-aburgess@redhat.com> <20220125160730.GA425591@redhat.com> <20220125172733.GB425591@redhat.com> <20220207100533.GE2706@redhat.com> <83iltqyfk7.fsf@gnu.org> Date: Mon, 07 Feb 2022 17:03:48 +0000 Message-ID: <874k5aa9sb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Eli Zaretskii via Gdb-patches writes: >> Date: Mon, 7 Feb 2022 10:05:33 +0000 >> From: Andrew Burgess >> Cc: gdb-patches@sourceware.org >> >> Hi Eli, >> >> Didn't know if you wanted to give this patch a docs review or not. > > Sorry I missed that. No problem. I pushed this with the fix you suggested. Thanks, Andrew > >> > +@item styling >> > +@code{True} if @value{GDBN} should apply styling to the returned >> > +string. When styling is applied, the returned string might contain >> > +ANSI terminal escape sequences. Escape sequences will only be >> > +included if styling is turned on, @xref{Output Styling}. > ^^^^^ > Please use "@pxref" or "see @ref" here. @xref produces a capitalized > "Note", which is not appropriate in the middle of a sentence. > > The documentation parts are OK with that nit fixed.