From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UJZcJnC3amI2JgMAWB0awg (envelope-from ) for ; Thu, 28 Apr 2022 11:49:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 98AC61E058; Thu, 28 Apr 2022 11:49:04 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=G9M95ign; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1ADD21E01D for ; Thu, 28 Apr 2022 11:49:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3693B3888821 for ; Thu, 28 Apr 2022 15:49:03 +0000 (GMT) Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 41FCC38346AD for ; Thu, 28 Apr 2022 15:48:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41FCC38346AD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 6129B10047486 for ; Thu, 28 Apr 2022 15:48:50 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id k6NtnDFe2kku4k6NunTFEM; Thu, 28 Apr 2022 15:48:50 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ANANYO9+ c=1 sm=1 tr=0 ts=626ab762 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=xinLef6ONWwXcC7ZoHoA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EjF9RfWf3CCdPD/6tyaQDCSnsD4un0bYVryqalBbrgY=; b=G9M95ign01d8/USset9LzNuM0M vU3FOzUcqj8hq0CfDJXIXVrE/N8i33mRKc0Ckep+BJZamnwADfiVzP8gWw2ZtMAbSqamu/J33Oa3U tDsCUvtvzy+Hbx59RNCgm96wT; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55694 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nk6Nt-001tqz-KX; Thu, 28 Apr 2022 09:48:49 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH v3 3/7] gdb/dwarf: pass compilation directory to line header References: <20220428033542.1636284-1-simon.marchi@polymtl.ca> <20220428033542.1636284-4-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 28 Apr 2022 09:48:49 -0600 In-Reply-To: <20220428033542.1636284-4-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 27 Apr 2022 23:35:38 -0400") Message-ID: <874k2dmcny.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nk6Nt-001tqz-KX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55694 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> + /* COMP_DIR is the value of the DW_AT_comp_dir attribute of the compilation Simon> + unit in the context of which we are reading this line header, or nullptr Simon> + if not applicable. */ Simon> + line_header (const char *comp_dir) Simon> + : m_comp_dir (comp_dir != nullptr ? comp_dir : "") Simon> + {} I think a single-argument constructor should be 'explicit'. Simon> + /* Compilation directory of the compilation unit in the context of which this Simon> + line header is read. */ Simon> + std::string m_comp_dir; Is there a need to copy the value here? I didn't check in this case, but often in the DWARF reader, a string will come directly from some mapped section, and in that case there aren't lifetime issues -- and so it's fine to just store the pointer. Tom