From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tl8ZMAQmBWPGLCwAWB0awg (envelope-from ) for ; Tue, 23 Aug 2022 15:09:56 -0400 Received: by simark.ca (Postfix, from userid 112) id B8F241E4A7; Tue, 23 Aug 2022 15:09:56 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZcoCXX3D; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 719F81E222 for ; Tue, 23 Aug 2022 15:09:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12E843858D32 for ; Tue, 23 Aug 2022 19:09:55 +0000 (GMT) Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 2507C3858D32 for ; Tue, 23 Aug 2022 19:09:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2507C3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 4F9AA1004157A for ; Tue, 23 Aug 2022 19:09:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QZHKoqiM8sbE6QZHKosX2Q; Tue, 23 Aug 2022 19:09:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=EegN/NqC c=1 sm=1 tr=0 ts=630525ef a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=3Tb8onoK8fgKV8TAyFUA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UfD+kNcXfP9DPDLdS/IyJFnNAEJTMe00OxlBA+ozeO0=; b=ZcoCXX3DIkwJ3lyYG1JSjopuUe aRSuaVSbaZx0lehAVuqfmkiYwQJZbZvPqc7oCHpxACK3vx5TBo2q0CpYQO7OoQR1Un+iQrqxmbbtI sbkohV+XJn+mMBgR9oxdZNdH2; Received: from 71-211-185-105.hlrn.qwest.net ([71.211.185.105]:56346 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oQZHK-003rFx-7H; Tue, 23 Aug 2022 13:09:34 -0600 From: Tom Tromey To: Patrick Monnerat via Gdb-patches Subject: Re: [PATCH] gdb: add a file event mask parameter to add_file_handler References: <20220819174601.144876-1-patrick@monnerat.net> X-Attribution: Tom Date: Tue, 23 Aug 2022 13:09:33 -0600 In-Reply-To: <20220819174601.144876-1-patrick@monnerat.net> (Patrick Monnerat via Gdb-patches's message of "Fri, 19 Aug 2022 19:46:01 +0200") Message-ID: <874jy2dbf6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.105 X-Source-L: No X-Exim-ID: 1oQZHK-003rFx-7H X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-105.hlrn.qwest.net (murgatroyd) [71.211.185.105]:56346 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Patrick" == Patrick Monnerat via Gdb-patches writes: Thanks for the patch. Patrick> +#if defined(POLLRDHUP) Space before the '('. Patrick> void Patrick> add_file_handler (int fd, handler_func *proc, gdb_client_data client_data, Patrick> - std::string &&name, bool is_ui) Patrick> + std::string &&name, bool is_ui, int mask) Patrick> { Patrick> + if (fd < 0 || (mask & (GDB_READABLE | GDB_WRITABLE | GDB_EXCEPTION)) == 0) Patrick> + return; Is there ever a situation where this can happen and it is not a bug in the caller? I am wondering if this ought to be an assert instead. Patrick> +/* Tell add_file_handler what events we are interested in. */ Patrick> + Patrick> +#define GDB_READABLE (1<<1) Patrick> +#define GDB_WRITABLE (1<<2) Patrick> +#define GDB_EXCEPTION (1<<3) I tend to think it would be better to use enum_flags here. Tom