Re: [PATCH 11/31] gdbserver: Hide and don't detach pending clone children

Pedro Alves
2023-11-13T14:09:33Z

On 2023-06-07 17:10, Andrew Burgess via Gdb-patches wrote:
> Pedro Alves <pedro@palves.net> writes:

>> - /* If THREAD is the parent of a fork child that was not reported to GDB,
>> - return this child, else nullptr. */
>> - virtual thread_info *thread_pending_child (thread_info *thread);
>> + /* If THREAD is the parent of a fork/vfork/clone child that was not
>> + reported to GDB, return this child, else nullptr. */
>> + virtual thread_info *thread_pending_child (thread_info *thread,
>> + target_waitkind *kind);
>
> Should the comment not say what happens to KIND? I think this comment
> applies throughout this patch where KIND was added as an argument.
>

Indeed, fixed throughout.

> Otherwise, this looks good.
>
> Reviewed-By: Andrew Burgess <aburgess@redhat.com>
>

Thanks!