Re: [PATCH 30/31] Centralize "[Thread ...exited]" notifications

Andrew Burgess via Gdb-patches
2023-06-12T12:24:11Z

Andrew Burgess <aburgess@redhat.com> writes:

> Pedro Alves <pedro@palves.net> writes:
>
>> Currently, each target backend is responsible for printing "[Thread
>> ...exited]" before deleting a thread. This leads to unnecessary
>> differences between targets, like e.g. with the remote target, we
>> never print such messages, even though we do print "[New Thread ...]".
>>
>> E.g., debugging the gdb.threads/attach-many-short-lived-threads.exp
>> with gdbserver, letting it run for a bit, and then pressing Ctrl-C, we
>> currently see:
>
> I'm currently writing some tests that run into this issue, and I needed
> a bug-id to use in the XFAIL messages. I've created PR gdb/30129 for
> this issue:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=30129

With the commit message updated to mention the bug-id and (some) of the
tests fixed by this commit, this looks good.

Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew