Re: [PATCH 05/31] Support clone events in the remote protocol

Pedro Alves
2023-11-13T14:06:13Z

On 2023-03-22 15:46, Andrew Burgess wrote:
> Pedro Alves <pedro@palves.net> writes:

>> @@ -2579,9 +2580,10 @@ remote_target::remote_add_thread (ptid_t ptid, bool running, bool executing,
>> else
>> thread = add_thread (this, ptid);
>>
>> - /* We start by assuming threads are resumed. That state then gets updated
>> - when we process a matching stop reply. */
>> - get_remote_thread_info (thread)->set_resumed ();
>> + /* We start by assuming threads are resumed. That state then gets
>> + updated when we process a matching stop reply. */
>
> If feels like that comment is now out of date. We surely aren't
> assuming anything anymore, rather marking the thread as resumed when its
> executing.
>
> Otherwise, this commit looks good.
>

You're right. I removed the comment. Tweaking the comment would just end
up with the comment duplicating what the code is doing in words.

> Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thanks!