From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y0IoO2sOh2TJ9QEAWB0awg (envelope-from ) for ; Mon, 12 Jun 2023 08:24:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=UWkryxzH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E31BA1E0BB; Mon, 12 Jun 2023 08:24:11 -0400 (EDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D402F1E0AC for ; Mon, 12 Jun 2023 08:24:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 085A13858414 for ; Mon, 12 Jun 2023 12:24:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 085A13858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686572649; bh=IHS98ctWguXB4ufjP36KDQS24mwf++TocvCjai2cmK4=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UWkryxzHAU+NB4p8dIO5SttwLYQQfsXay1vK3uubIrxALhdtB4G8stogBYnlm/Ycw aNdYB6JOQwNb3DNV3tI+1aIcTrm0rAwliSsxVuVxHLlEkAnqasx1m4bXIMgkt1t3Y8 TfrRo9S0rAwEMk2jMyfbXmSzuze7a/7zuR9yUtg8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 81D843858D32 for ; Mon, 12 Jun 2023 12:23:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81D843858D32 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-3x0axxnpPyum8o4yTywiHA-1; Mon, 12 Jun 2023 08:23:47 -0400 X-MC-Unique: 3x0axxnpPyum8o4yTywiHA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4f6275fdb9eso2808201e87.2 for ; Mon, 12 Jun 2023 05:23:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686572625; x=1689164625; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IHS98ctWguXB4ufjP36KDQS24mwf++TocvCjai2cmK4=; b=N7nsg2v0V61Si2X7mNE/qPS28R8ULdir47on2WLB+gHJdxrTZHC1ZXv5Sh2zZSCENW dXxbXXXzMG3lfjSiZa36RjzTxsXzExyDHoLHtdOV++gaLKGdT0XDA6uCi2jVod6oujaV EkOjmHW8C47Dk2hWrOupnqUxom+sF5DHAL3aWU/gEbO4hlseBdHKZ7Sqd9FYMvhzYCYm j/Dg3hwGsGu9Ze2A/XDyvLUatZKx6ZRt0Uze8fm0ztJyDkkemD6sniF5Qa9VxD23QmkR exvpNqAr2tIXXjAdYKG7xsm43HvUAcIqd5+7a+S0/o7/rK0CUsbMjFHJBOF14G9vOHe+ 63Jw== X-Gm-Message-State: AC+VfDzjev6NSubJ1djHgFZ95CLHhsd7RewJPfdoYgQJVBwsNV5lUPMb SHa8+/CVGwlKOT7EUUG+Mx6i+s5YucxW4xyWWK1LLEOtO1dK/W2cxF5LC5TyxU7W4MqXer7Y/vu kOoHaqo4tKOsWVc6D198bJSRDG94s+w== X-Received: by 2002:a19:655d:0:b0:4f3:5038:5857 with SMTP id c29-20020a19655d000000b004f350385857mr4038159lfj.55.1686572625569; Mon, 12 Jun 2023 05:23:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4iHHRrLLHyCt0Ly/S6Eydra9x+oBakWZ17g9pFatriA/b8SwGP1OIiYh7W2+VzCh4japq/9A== X-Received: by 2002:a19:655d:0:b0:4f3:5038:5857 with SMTP id c29-20020a19655d000000b004f350385857mr4038146lfj.55.1686572625281; Mon, 12 Jun 2023 05:23:45 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id k20-20020a05600c0b5400b003f4266965fbsm11369179wmr.5.2023.06.12.05.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 05:23:44 -0700 (PDT) To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 30/31] Centralize "[Thread ...exited]" notifications In-Reply-To: <87ttzlliua.fsf@redhat.com> References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-31-pedro@palves.net> <87ttzlliua.fsf@redhat.com> Date: Mon, 12 Jun 2023 13:23:43 +0100 Message-ID: <874jncyils.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Andrew Burgess writes: > Pedro Alves writes: > >> Currently, each target backend is responsible for printing "[Thread >> ...exited]" before deleting a thread. This leads to unnecessary >> differences between targets, like e.g. with the remote target, we >> never print such messages, even though we do print "[New Thread ...]". >> >> E.g., debugging the gdb.threads/attach-many-short-lived-threads.exp >> with gdbserver, letting it run for a bit, and then pressing Ctrl-C, we >> currently see: > > I'm currently writing some tests that run into this issue, and I needed > a bug-id to use in the XFAIL messages. I've created PR gdb/30129 for > this issue: > > https://sourceware.org/bugzilla/show_bug.cgi?id=30129 With the commit message updated to mention the bug-id and (some) of the tests fixed by this commit, this looks good. Reviewed-By: Andrew Burgess Thanks, Andrew