From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id P4TACZIdo2SO2xQAWB0awg (envelope-from ) for ; Mon, 03 Jul 2023 15:12:18 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SSYCeS1f; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 18E691E0BD; Mon, 3 Jul 2023 15:12:18 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFF081E0AC for ; Mon, 3 Jul 2023 15:12:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E4F8385770B for ; Mon, 3 Jul 2023 19:12:15 +0000 (GMT) Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 7D92B3858D32 for ; Mon, 3 Jul 2023 19:12:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D92B3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 7786410048298 for ; Mon, 3 Jul 2023 19:12:00 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id GOxsqZZi162ewGOxsqium4; Mon, 03 Jul 2023 19:12:00 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Os2Kdwzt c=1 sm=1 tr=0 ts=64a31d80 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=h3uVbLRKWcgiAsVxR-EA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fPC4NVne684NJZ+2x7ut9uKAhe6BV6rlVx3/sGSek7E=; b=SSYCeS1fXgN+k0FDjzlUYA+LX2 Me1fSgV2qGgfe1WhDsygOq816mI9QazXaqspao/JWxRYQFlYcZ7zX2XIW65FaDEbBtSTy/MkGBLYW MDG/wb+RQS/ekTLFV9cS3iIi6; Received: from 71-211-136-248.hlrn.qwest.net ([71.211.136.248]:51200 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qGOxs-003xSt-0T; Mon, 03 Jul 2023 13:12:00 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre Subject: Re: [PATCH v1] gdb/DAP - Add completionsRequest References: <20230628162616.102268-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Mon, 03 Jul 2023 13:11:59 -0600 In-Reply-To: <20230628162616.102268-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Wed, 28 Jun 2023 18:26:16 +0200") Message-ID: <874jmkx11c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.136.248 X-Source-L: No X-Exim-ID: 1qGOxs-003xSt-0T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-136-248.hlrn.qwest.net (murgatroyd) [71.211.136.248]:51200 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Farre via Gdb-patches writes: Simon> Self-explanatory. I think it's preferable to write something anyway. Simon> + Simon> +def _completions(text: str, column: int, line: Optional[int], frameId: Optional[int]): This should be marked @in_gdb_thread. Since 'line' isn't used, I think it can just be removed here and also from 'completions' itself, as it is optional anyway. Shouldn't 'column' be used? Like perhaps the text should be truncated at the given column. (It's also fine to do this work in the main thread.) Simon> +def completions( Simon> + *, Simon> + text: str, Simon> + column: int, Simon> + line: Optional[int] = None, Simon> + frameId: Optional[int] = None, I notice that frameId doesn't do anything either. Since it's optional, I suppose it could just be dropped here. gdb doesn't really have this concept, though we did add it for expression evaluation to support DAP, so maybe it should also be added for completion. Tom