From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZdQHO5qLLWUNmC8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 15:14:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=C33oYe9y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E2CEE1E0C1; Mon, 16 Oct 2023 15:14:34 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B40241E091 for ; Mon, 16 Oct 2023 15:14:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3CAB9385703A for ; Mon, 16 Oct 2023 19:14:32 +0000 (GMT) Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 6C4083858401 for ; Mon, 16 Oct 2023 19:14:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C4083858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6C4083858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697483661; cv=none; b=T6c9irZXL+RC/B9jOkavKxGeIy5ZiLLqsZoNTFo9URRbJ0gV7DpWbbbprQTnFSnl6T8tZEqSoZMkDlWHfvFAwsYRuaAGQ9/oEiZgig6eGr+vyKF4XUIa7So5eHmaz9sXpH4OgCP3csUMKT3qJ/7QWzfBR06pqGY8B1hvIkmixaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697483661; c=relaxed/simple; bh=cZOHEsejDGDjNJXmZfcE/dKUmV0egPfknp82zfKb7H4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gx2lQGGU3Ts9cbKgSlE7lP49dPyYFYVTVVu1OeDjl2fVHQWb3NFlE9d+b9Fvh2b1eRNU4WWmR9WfgLbWI37fvIRnsA0t7IuG4Yt3JzrKOqvuqPlNjheWFF4mSrrd3sPDjJBF03b7aYZb7WWjkzpZ6mTmv/nl5Lt7RQ/VL4BWUy0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTP id sSNNqCo9CQUgRsT2gqgLSe; Mon, 16 Oct 2023 19:14:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id sT2eqM3cHxLBtsT2fqHIEv; Mon, 16 Oct 2023 19:14:17 +0000 X-Authority-Analysis: v=2.4 cv=Ztj+lv3G c=1 sm=1 tr=0 ts=652d8b89 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=GMRsv1kbstyf2B-IotUA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FnnLl6dzylTITOcGz+lwqEo/YeJ303tdpK99ClA+06Y=; b=C33oYe9y19epInS0m/gur40qIF dUHdQUBAKZJRv5vo5pBIyLlZ5EWTGzsYUnic45FlI9Js/7o2iSNtcQBS6HbyQpOf9OWJGTY1cK6Qz K9hg564P+LnizqXRTwbrwZ6om; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:34100 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qsT2e-0011Qk-1q; Mon, 16 Oct 2023 13:14:16 -0600 From: Tom Tromey To: Lancelot Six Cc: Subject: Re: [PATCH 03/11] gdb: Use C++17's std::make_unique instead of gdb::make_unique References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-4-lancelot.six@amd.com> X-Attribution: Tom Date: Mon, 16 Oct 2023 13:14:15 -0600 In-Reply-To: <20231013144418.3180617-4-lancelot.six@amd.com> (Lancelot Six's message of "Fri, 13 Oct 2023 14:44:10 +0000") Message-ID: <874jiqs7lk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qsT2e-0011Qk-1q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:34100 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAyVW4C99q2EgpMiCskfTTdpZyWYeoYw7FiYEEv04KsfbUeiZxKQYnHqU0AUL59aBavPZyinTvHG+HTd1ZMPcevR3RtccL6dvIoaX37IKzX3Gg6kHelw R3mWMdnlE7JCBhJdW8xuGS7gZqA9COMxHN26RO9QGrUiRW+EzQ3XAxfkD4KzJuV/nrkJ3Lhpgu7ANXjZV5P2w+zvuS2tcazefOo= X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot Six writes: Lancelot> gdb::make_unique is a wrapper around std::make_unique when compiled with Lancelot> C++17. Now that C++17 is required, use std::make_unique directly in the Lancelot> codebase, and remove gdb::make_unique. Lancelot> +#include I don't really understand why these includes are needed, since gdb_unique_ptr.h includes , so presumably it's already visible at every spot that's being touched. Not sure it really matters, but I was curious. Tom