From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FDqJDQxT62W/Sz4AWB0awg (envelope-from ) for ; Fri, 08 Mar 2024 13:03:56 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KGyUaBFp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2813F1E0D2; Fri, 8 Mar 2024 13:03:56 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1578E1E092 for ; Fri, 8 Mar 2024 13:03:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9FC41385E03D for ; Fri, 8 Mar 2024 18:03:53 +0000 (GMT) Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 629653858D38 for ; Fri, 8 Mar 2024 18:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 629653858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 629653858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709921010; cv=none; b=P3NUZbaPaqr5FEgBf9ygCCDeC8J1zVVDr/e7wrgN9zAhmO0FiKPGW9BB3QKhlWs+RO1G6bYlgO355MLF988CapRwVZjPFZx9bGuJRRWV+1kn5Hf/uN5xggNOmsRZ4BOIJJoZAYILqz0SjeK0H1Kukmo3BcMuzFV6F1dGZ3vzhUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709921010; c=relaxed/simple; bh=twLW8bfSnLeYaww39miLtOGb+872WnZZUH8gHRyXkcs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AdCsS+b44gyn7Oz/bcSV40RzULGmFsoCppJN8MElAj5MgbS1kRrDMa4N/iljX0INM7OD9g3gb92f7LYQ+AeSsaO55G/vmrJKzhunqeSmax2/mEen1alsL5LH6Ae/UF6pcQ/daud8nlS1P2hA90c2pesT447nXslAn0yA/OLuhm0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTPS id ibGarwNvpHXmAieZ3roOOG; Fri, 08 Mar 2024 18:03:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ieZ2rjjFndeujieZ3rctI5; Fri, 08 Mar 2024 18:03:25 +0000 X-Authority-Analysis: v=2.4 cv=IuQYcq/g c=1 sm=1 tr=0 ts=65eb52ed a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=CCpqsmhAAAAA:8 a=5q5C7cec1xCU_uuojNYA:9 a=JtLNF05ssIIA:10 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kWGxRoIItGHGwajUHE4l4+sO01Kx/Ma8TLz6RSJ0auM=; b=KGyUaBFpQoK0/Dcz1jLgwvUgES h+3PU017KNpClfHbi+QV72oqBK2+xlLx7k64Y/L5Uh0f3k93oSeVAn27ys0O7rYQCRyB4pmPsfGd7 afSMO5nw27nwZwyBhgZVc+XiF; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:60282 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rieZ2-000bsa-1G; Fri, 08 Mar 2024 11:03:24 -0700 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Revert "Pass GUILE down to subdirectories" References: <20240123001928.787780-1-tom@tromey.com> <877cifbr60.fsf@redhat.com> X-Attribution: Tom Date: Fri, 08 Mar 2024 11:03:23 -0700 In-Reply-To: <877cifbr60.fsf@redhat.com> (Andrew Burgess's message of "Wed, 06 Mar 2024 10:17:27 +0000") Message-ID: <874jdgr47o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rieZ2-000bsa-1G X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:60282 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDdPaPtpplJUSb8ZdM7ij5+qNWBKnVtKlaouKRKJGvOUTP9rALYCgqBfxfly+aPj2nNTh4dAF3mR9T+TLHoiA0lb19XB1zurDSxdopRQFCRNdLP4q4u/ X7NLhv7z1nXNBj8Q+JUfNQA3xdADkfXudRIFH3V+0/nkTb+8sC0qzMkwFezWgg/KrB7/4Oxh7TukeRXkyC1Cf1PooObjdA58bKk= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> After once again forgetting to add GUILE=guile2.2 to my GDB build I was Andrew> thinking about this issue again. Andrew> Given that GDB has a --with-guile=... configure option, and that our Andrew> configure scripts try to identify a matching version of guild and a Andrew> shared library to link GDB against, I wondered why we don't just force Andrew> the use of a matching version of guile. Andrew> I guess I'm suggesting that for building GDB's guile components we Andrew> should respect either the --with-guile=... configure option, or what the Andrew> configure script auto-detected, and should not be picking up any build Andrew> time GUILE=... flag -- setting GUILE=... isn't going to change the Andrew> version of guild used, nor is it going to change the shared library that Andrew> GDB links against, so just changing the guile version seems like a Andrew> recipe for incompatibility problems. Andrew> Below is a patch that forces GDB to compile our guile scripts using a Andrew> suitable version of guile. This could be applied irrespective of Andrew> whether you revert b7e5a29602143b53267efcd9c8d5ecc78cd5a62f or not. Andrew> What do you think? I have no issue with this. If it helps you, you should do it. FWIW I was waiting for a response from you before reverting this change. https://sourceware.org/pipermail/gdb-patches/2024-February/206507.html Overall I think that we really should revert my change. cgen isn't run commonly enough to warrant the change breaking literally anything else. And, part of this is on cgen for not coming with any kind of script for running it ... actually looking under the hood has really soured me on cgen entirely. The guild #! prologue also seems like an obvious bug to me. However it's perhaps too late to fix this in any useful way. Tom