From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lpr4JE/v8mVhzAYAWB0awg (envelope-from ) for ; Thu, 14 Mar 2024 08:36:31 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=NJCEKl6W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8946B1E0BB; Thu, 14 Mar 2024 08:36:31 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 735A91E01D for ; Thu, 14 Mar 2024 08:36:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2963E3857839 for ; Thu, 14 Mar 2024 12:36:29 +0000 (GMT) Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id CFC403858C3A for ; Thu, 14 Mar 2024 12:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFC403858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CFC403858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419770; cv=none; b=GCPmxC/pNp1DUwLq2Add8vzL5+lX3IBa76KmST1VReBIvuPG8rFJ9FYrovdjpFN1I01+2ikD3N6oFCHRLaeuUNe/cIANYBAE+tqQnCHwtMhhEWdClxBziezVhkYYmOKzL2Oa97tXWEQxjqzcbI9bOgrhP5FNI3+OMikWXqQR8MQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419770; c=relaxed/simple; bh=FDnKseAnVKwgxA3EtcyZk/RPdAplUXYz/l3U59xxekI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=d/vvgdd3iDA7kWYcYs8yUUXy2t9iBPj1Kzn6L9+vRmvn987vOVbxQgAZskrVC046D0eUhvTuPwh13FqSufRtFRYOAJxwn1nwx/mN+laujpIiLkpZ70PZtyU5tkKt9X+2vxpnPg4PTUNlfm+/GVwKnKAL7k+ukh9O/aKaD1fW1Mk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id kjCXr39iNtf2QkkJcrlCB8; Thu, 14 Mar 2024 12:36:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kkJbrX7Qh0ulnkkJbrTeZb; Thu, 14 Mar 2024 12:36:07 +0000 X-Authority-Analysis: v=2.4 cv=XY6Pzp55 c=1 sm=1 tr=0 ts=65f2ef37 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=5dseFAyKFTZOXoz04tkA:9 a=ZXulRonScM0A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oCJHmjZB1qkaKxCeps+Ns3JGe/3N1RVbse0zE1Gnv/0=; b=NJCEKl6Wy0ZylIXgtBaUWd6Vue x6YlGEIQKuCyGegI9SJ8wy83xuoSW6p7CN9KD+RYzR/6vvQ0qYTP6mQcqw2bqG/IdYYcEiGsBNUDu Blrd1jRaJg58pvP2JdafaaKGN; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:46170 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rkkJb-002XWe-0l; Thu, 14 Mar 2024 06:36:07 -0600 From: Tom Tromey To: Aaron Merey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev References: <20240313201827.1853989-1-amerey@redhat.com> X-Attribution: Tom Date: Thu, 14 Mar 2024 06:36:06 -0600 In-Reply-To: <20240313201827.1853989-1-amerey@redhat.com> (Aaron Merey's message of "Wed, 13 Mar 2024 16:18:27 -0400") Message-ID: <874jd9m1mx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rkkJb-002XWe-0l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:46170 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLsHjlN0Zq2V8XLZJ5uxZxz923bVDoCIDYSfsHP3awXZ5aVh21gH2CBo2znpQ+v1pwRI+ah5wtc+GtIstZvo47wjmIQubotKkpmiTXHsckp0I1aUJDdf SzHx4PHXXyQpaxbkfHc26Fzfzr3KwMkMX9lPWgKv9cTDYMfF11GIVXioLgxWHkuLRYlUODtYbf4aui1/oO0ibY0grRiLyc5j2xo= X-Spam-Status: No, score=-3015.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > A corrupt debuginfo file can result in a null abbrev_info pointer > being passed to cooked_indexer::scan_attributes. There is no check > for whether the abbrev pointer is null and SIGSEGV occurs when > attempting to dereference the pointer. Also, I was wondering if this case can be tested somehow. Perhaps the DWARF assembler could be modified to allow the creation of corrupted debug info. It seems to me if we're going forward with the security policy, then we're going to need to test these things. Tom