From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pDdDNX5iFWZCOCkAWB0awg (envelope-from ) for ; Tue, 09 Apr 2024 11:45:02 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nGQnoKV1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C45881E0C0; Tue, 9 Apr 2024 11:45:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA6C91E030 for ; Tue, 9 Apr 2024 11:45:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C7783861870 for ; Tue, 9 Apr 2024 15:45:00 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 8924B385841C for ; Tue, 9 Apr 2024 15:44:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8924B385841C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8924B385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712677479; cv=none; b=A7aSOpOa8BFGRtUPvolyhCQOAkQoMI6sIlD593TM4g6aF3VtnzpjopB0cj3XoIE5xOmoHGKeUUBQQaAczZkAtkk7NyTzrHNWN15VGuhobqzYIFYK1NJ77oHMD5yRa4CCfCRgBmq9BQw8hh+f8pSp1oiUGWa0Md5svsRtXfoRl0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712677479; c=relaxed/simple; bh=jNiHPkamMy5QGv5ODcB3hdkhITesTOCjNElu22G61yc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ShyjlfFBXq80avUIpLTRI+9qVSCnvBmKmLVPOu64/dllGxbBpvHtnPAFuylqtv9MMxCaqwSAxiQUtUNzH+UBmItOmWbAp1cu5Bg7F5aDkQ4kunqcfqbUCmK0mRIZDN9khfr9Rvc2A8yshw4lU5qE5W2gu4Zaw3xXSZEYXSd9BL8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id uD4QrNGWduh6suDeHrzdUT; Tue, 09 Apr 2024 15:44:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uDeGreskiWqfjuDeGrSYve; Tue, 09 Apr 2024 15:44:36 +0000 X-Authority-Analysis: v=2.4 cv=GsNE+F1C c=1 sm=1 tr=0 ts=66156264 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=QATRCr1_wsNjFEdMK_EA:9 a=zgiPjhLxNE0A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xSmRBGkCgKz9AC5qqfp8fAGCUduZOCwFct5PCtwyZp4=; b=nGQnoKV19ReMpHqqQzMf2KksJR BLSZ7zdsVMp0I3V9R0xCn2EnCA0vkaVkpyshniEAnkuKd+E/Cmqc5vFY1PEMNBxiVLg0K2rCcPObL xJBfUkAPg48BZ25W8rgJwIAkq; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:36014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1ruDeF-0028Ha-2s; Tue, 09 Apr 2024 09:44:35 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Rewrite gdb_bfd_error_handler References: <20240314184928.544952-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 09 Apr 2024 09:44:34 -0600 In-Reply-To: <20240314184928.544952-1-tom@tromey.com> (Tom Tromey's message of "Thu, 14 Mar 2024 12:49:28 -0600") Message-ID: <874jca5yn1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1ruDeF-0028Ha-2s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:36014 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIl2xJD+cAXWBh+kB24lAVoM03k/Wuur9DzG2QzJ4sZdBqYgf3JUn3CkIC01V6ko55Fsy3UjeFG9gBHVRf4yRCfXypZMaIbnc36d3yW/xQa3nHLfaYLY iMi/2K0sFciFtqnfaMl30LZ1HtpFVVEy1+bsBNvz6wGZy7PUsOCyzY3eWLkjLa0uMdKA3HBNqY8Ek55GkPnZ6IDedusLZNMKawQ= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom Tromey writes: Tom> This patch rewrites gdb_bfd_error_handler to use 'bfd_print_error' to Tom> generate the text of the warning, and then emits it using 'warning'. Tom> The current code in the tree is a bit wrong because it may do the Tom> wrong thing when BFD uses ones of its printf extensions. Tom> This also adds locking to increment_bfd_error_count. This is Tom> important now that some BFD operations can be done on worker threads. Tom> This approach makes it simpler for worker threads to intercept any Tom> messages. Tom> Regression tested on x86-64 Fedora 38. I'm checking this in. Tom