From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iLjuChMNJ2ag1DgAWB0awg (envelope-from ) for ; Mon, 22 Apr 2024 21:21:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Dckg084C; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 190DA1E0C0; Mon, 22 Apr 2024 21:21:23 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFFE81E030 for ; Mon, 22 Apr 2024 21:21:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48A71384DD00 for ; Tue, 23 Apr 2024 01:21:20 +0000 (GMT) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 0DB493858D38 for ; Tue, 23 Apr 2024 01:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DB493858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DB493858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713835260; cv=none; b=PeO6jXVLndptSaD/TAuIJkfp9nGIUNouXeXuIt+oN1NxqFM20pnvERPwviirVTEKjjfkbwIZH+WxDPis6qqcwfXSn19psGLAt3hJglHkEAFcNY+SiIJ36eD2+wMtj2H4ZtM5W4U/xLv/vTAwkUDEfrSTeclvCVuoGn9uGKtIRBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713835260; c=relaxed/simple; bh=6xjON/dckeCjwP16sXEzBqPfW2suG4xCbP9TTVMmqs4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=venaOg1go9w2RARh48vucXbDVINUGyXP8mSpnAbNdBC19oorvYRPyRrCHBtjqEsJSLhYoNQzWV+eDWfFvHBV1IROGP3mfYFSF8KO/4+sRjwMa5VciIJFXTMKbGI70W5AVPjto9ZEliLMmb4ntOOsKdggtoOcZRF7cJtXrAL92QA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1e5c7d087e1so40944675ad.0 for ; Mon, 22 Apr 2024 18:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713835257; x=1714440057; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=h0gCigJBcMD/1Ju2gGfEJ8v/LYHnjPL7Yp0S538D9rA=; b=Dckg084Cc30Y3AmkWKhUqGqTs9BNaVo56KZ9cReuGDpA+DVu7FMmZMWWNclMVURgVf D0UKWDlZPoHwHYOxdQ8tepkuqpveiwgJGx0SOd06A9EMIqdn41hKV6Mz0cUwFQr5JI+Q phXD0rHdyoIgxIQC7bmrcSpEe37WN5Vs7zBFSWN9pW69RH22jHilDJnY69oT1BgeNp23 BvRGhrKDPMIXuHNZPMqPWcet097LdIQOgNcGBeFbcVXt+X2bOxQMcOE2J4SLN8lLviXv jTjiv82MmxbUTyOstYgJTHhbQqeG40SXErmYmBmyY1Ae5bSSznrWXTUBBUkh5TkfPKM2 A+Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713835257; x=1714440057; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h0gCigJBcMD/1Ju2gGfEJ8v/LYHnjPL7Yp0S538D9rA=; b=EOrAnFOV1QqP5tzxhQ4H7y+iJkxbcDFLEtLUd4uprbTojSXQdXuimP07zeW8cWbase y5qYjIYniFud+ZJFStyhXqBtyT6Nex6hEmORTp8iio4IORY4B4l/X9CVbvIIkR8M3wQl 1bIl2MmevnLkNToijKumfTZnlkLIZbkhcyoDB1l8wPWHnHYMCfu/5nbzCxp6Etgv2qSM GyECONmEwVJnVTEQRM7JYz3Qaf4KiAKgWeIBJ4PC4p7YvDswOI6cH+ab70FSDcKbxGuE gWpbVzN0pxLHGP2ou30F5Mk1Ug0NdJ9dJsm3O7NUW1ZPwCtOOE24B8wfZ8ITwKHYaWAU luIw== X-Gm-Message-State: AOJu0YzpWL2sNb0TJHyVSfa/XBEJ7NUHQGYw3CfwaYVgj+G7ikdBbsb+ NNgl8giqDO4ilpv5wILn6qV+xNmcFJGK6Rh1yRKXakff3c0hM1xya9iCR7IS2jM= X-Google-Smtp-Source: AGHT+IH7CqFzNB29MhnCCekmHvtEmodrO8gSZP4b2990ylQCoWKANAKPL2G/D9r8qN/fwTSP5TQW1w== X-Received: by 2002:a17:902:da85:b0:1e3:e137:d3af with SMTP id j5-20020a170902da8500b001e3e137d3afmr13330828plx.9.1713835256794; Mon, 22 Apr 2024 18:20:56 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:25e4:a74b:cf9:5423]) by smtp.gmail.com with ESMTPSA id n18-20020a170903111200b001e0b5eee802sm8732982plh.123.2024.04.22.18.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 18:20:55 -0700 (PDT) From: Thiago Jung Bauermann To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb/testsuite: Add gdb.base/memops-watchpoint.exp In-Reply-To: <20240422114017.64cf2adb@f39-zbm-amd> (Kevin Buettner's message of "Mon, 22 Apr 2024 11:40:17 -0700") References: <20240420213307.976401-1-thiago.bauermann@linaro.org> <20240420213307.976401-3-thiago.bauermann@linaro.org> <20240421142019.0f6d75d0@f39-zbm-amd> <87wmoq2qid.fsf@linaro.org> <20240422114017.64cf2adb@f39-zbm-amd> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 22 Apr 2024 22:20:52 -0300 Message-ID: <874jbs3mdn.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > On Sun, 21 Apr 2024 21:24:42 -0300 > Thiago Jung Bauermann wrote: > >> >> +require libc_has_debug_info >> > >> > I'm wondering about the need for this requirement. When I comment it >> > out and run it on a machine without libc debuginfo, I do see 3 FAILs, >> > but it seems to me that those could be turned into PASSes by changing >> > the regular expressions for the "continue until..." tests. > [...] >> >> I added the requirement because in my aarch64-linux system without libc6 >> debug info I get: >> >> continue >> Continuing. >> >> Hardware watchpoint 2: -location a[28] >> >> Old value = 104 'h' >> New value = 0 '\000' >> 0x0000fffff7e90664 in ?? () from /lib/aarch64-linux-gnu/libc.so.6 >> (gdb) FAIL: gdb.base/memops-watchpoint.exp: continue until memset watchpoint hits >> >> And I just tested removing libc6-dbg from my x86_64-linux laptop: >> >> continue >> Continuing. >> >> Hardware watchpoint 2: -location a[28] >> >> Old value = 104 'h' >> New value = 0 '\000' >> 0x00007ffff7d8e05f in ?? () from /lib/x86_64-linux-gnu/libc.so.6 >> (gdb) FAIL: gdb.base/memops-watchpoint.exp: continue until memset watchpoint hits >> >> So it depends on the system. > > What distro are you using? Ubuntu. Version 22.04 on some machines, and version 23.10 on others. >> One alternative would be to not use the require statement and run the >> test until the watchpoint hits, and have a case in gdb_test_multiple to >> mark as UNRESOLVED if the function name is '??'. > > I'm in favor of this approach. > > If we stick with the require statement, I think that Fedora testing > will frequently show this new test as unsupported since installing > debuginfo is less common / important that it used to be. (This is > due to debuginfod doing it for you. But I think that debuginfod is > mostly disabled when running the GDB tests.) Yes, that is a good point. I think v3 should work with the output you pasted in a previous email. Thank you for bring this up. -- Thiago