From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wIEQJpDhYWbNpigAWB0awg (envelope-from ) for ; Thu, 06 Jun 2024 12:19:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I9bJw5c5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 96E001E0C1; Thu, 6 Jun 2024 12:19:28 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 813D51E092 for ; Thu, 6 Jun 2024 12:19:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A38238EB1D8 for ; Thu, 6 Jun 2024 16:19:26 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 4DA2738E9D90 for ; Thu, 6 Jun 2024 16:19:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4DA2738E9D90 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4DA2738E9D90 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717690749; cv=none; b=lfm2vWByhG4iJ6hecUBZND3vFYKmS+j4ALj0fkjhMi1gkxwDyQjDthpzOvNU2ZxYe4/zZYg9mgsXVm3PtBHDQD3eyk3uz8ZS88G5teX6ffl6B54OL6xfyCTq2LMWkw8pGZGTBj1O3IU01HWLORXktZTIQHWF0VJqzvXwq27zr1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717690749; c=relaxed/simple; bh=pUq8p5oiFlnG5RvlPtHgkXCxH9RRel+SvAI8EH/rXT0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BprK2f5WEnrCdjY/1fgpH6SgEGecl1zNiT7Jj6YaUmALeGCTkVl++v7xMyMKiUyYjCUp/lhyBf0PuaHslNtu40m0+40kbT6rx5L5XpMQFmXnTjfrQfQQiNrRtqXf9zJftEf+Qx8AJoFUGzprSKI+vXUUU3y/Ak82t3b5OB38cjg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id F4IGsd6IiSqshFFpTs3Hat; Thu, 06 Jun 2024 16:19:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id FFpQsCvKDXw7yFFpQsOZKx; Thu, 06 Jun 2024 16:19:04 +0000 X-Authority-Analysis: v=2.4 cv=LtSUyGdc c=1 sm=1 tr=0 ts=6661e178 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=T1WGqf2p2xoA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=GHNNQg8qcj844V5ZGOIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TA79JgHRYx+z9aeCp+/rkdSdiARLBLoH0hWVPKZaAP4=; b=I9bJw5c55wAMWlHn/mTzkbmuRF PKp2Qqc8tHN8dB5fVMWwjVT8v8AxmEeG7ST9ND/y4LNf37Hg2g6ZOfb1bwDJvkh+MfLm4TJG6Zr6G 7JmcI7/8ZWtBfxJvzQaPICrYa; Received: from 75-166-134-4.hlrn.qwest.net ([75.166.134.4]:58054 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sFFpQ-000duh-0i; Thu, 06 Jun 2024 10:19:04 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 3/7] gdb: move display of completion results into completion_result class In-Reply-To: (Andrew Burgess's message of "Wed, 5 Jun 2024 14:36:03 +0100") References: X-Attribution: Tom Date: Thu, 06 Jun 2024 10:19:03 -0600 Message-ID: <874ja6nix4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.4 X-Source-L: No X-Exim-ID: 1sFFpQ-000duh-0i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-4.hlrn.qwest.net (murgatroyd) [75.166.134.4]:58054 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfALnL0XzUpG/3PPJj5S4uUmnRSTNLOTbhON+sOWhrt0KFFTmlQUaBw4uhwXMydTIQF18l6vmzCpnwqtcZBkSQlxu5NpG6MBdz3X31HXP3mh0XN5Xrnxu ocqfGs0c/DY36Gcrgh5t2gSMsUeP7794me+UZ5nriDCzgd9T18Ya9u2a6+mqKHdGRAsbGgiJ/Rc49MOf3LSORatkiQU6msMhGCE= X-Spam-Status: No, score=-3014.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit moves the printing of the 'complete' command results out Andrew> of the 'complete_command' function. The printing is now done in a new Andrew> member function 'completion_result::print_matches'. At this point, Andrew> this is entirely a refactor. Andrew> The motivation for this refactor is how 'complete' should print the Andrew> completion of filename arguments. In some cases the filename results Andrew> need to have escaping added to the output. This escaping needs to be Andrew> done immediately prior to printing the result as adding too early will Andrew> result in multiple 'complete' results potentially being sorted Andrew> incorrectly. See the subsequent commits for more details. Andrew> There should be no user visible changes after this commit. IMO it would be fine to push this one separately if you were so inclined. Approved-By: Tom Tromey Tom