From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6FYXJy1mN2i5PzgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:38:21 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VnkVUUsX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9BC051E11C; Wed, 28 May 2025 15:38:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3153E1E102 for ; Wed, 28 May 2025 15:38:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E24DD385C41B for ; Wed, 28 May 2025 19:38:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E24DD385C41B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VnkVUUsX Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 29B0C3856DFA for ; Wed, 28 May 2025 19:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29B0C3856DFA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29B0C3856DFA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748461071; cv=none; b=giTtsHS3CWQrcUK4TLBUZkhe4MKgwKedUP4lwRbVbwDuPMcSdiYjVyuZ4UadYKovmEQ7wZW6mLIL72e3dXk3VrLjTbSBvjceM3EoSW31IU0xfOdAw4sHoEkHMi4GKDn1JO7B9NVPQYC2PtQYUTFq1E168iBdeVdfydGDoa3yA/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748461071; c=relaxed/simple; bh=T0+pRipl2L9URjhYLs3TixENxk7Wp9OXLx6ZCOh8iqM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aJuSDp1hUsDfHxUW2qzMru2i63lkkFQ3S8xeoMXVfRY5p4J47tPBqau1HL7DRXk/1OhAc3NrVMruzunVcq6GV0qu4fqNAQj0th3xLRWl4jmluSwMLkZKiL9uZR3KJZEElNEJ8nOGEtXB853kfLaQZQW7nrqufDOKNZRwNveUF5s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29B0C3856DFA Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id KDZuuNT7vVkcRKMb0udFMa; Wed, 28 May 2025 19:37:50 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMazuxlYI3IrfKMb0uAWvd; Wed, 28 May 2025 19:37:50 +0000 X-Authority-Analysis: v=2.4 cv=PL4J++qC c=1 sm=1 tr=0 ts=6837660e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=sWKEhP36mHoA:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=mkv1gAjVDEbo8XhgAhMA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nVThFRLyYY/2X/GeQi3EgCVNtOnokVLBQSW/GV8aBag=; b=VnkVUUsX8Gcv667fasB3EBfCEF DXXtSQSkh0IWq05w03Zb6Tq5vRpXQvUf1uWDxwyCnhv+2ss/bEyNE/yx+xoerA0kRiLAdT6u0sO2v sxi20BTjwdqmIDG9jqFHjSfCV; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:48310 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMaz-00000002nbV-2APU; Wed, 28 May 2025 13:37:49 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 32/47] Windows gdb: Change serial_event management In-Reply-To: <20250519132308.3553663-33-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:53 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-33-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:37:48 -0600 Message-ID: <874ix4frw3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMaz-00000002nbV-2APU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:48310 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKHXC75P3MzN2RwIiYouSusowKbEkPrvBlI2KntnWAqoam1Bn15syEU4PSCkerGZyElMJe9CpQ6nV9YA0cYJmP2pRvDReFQCIlxthlqrrR7ThJllwbKp j9ulTtPuXpNhr4d23UKWXTxnorlIpmimzb21TQURRKtbEQP7Fxw0Vd0qwJ5MWhkfSHBEgD5s52nfpE+UQ1kwufzRqzd2gWFKKM8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> This patch makes windows-nat.c manage the serial_event similarly to Pedro> how linux-nat.c does it. Clear it on entry to Pedro> windows_nat_target::wait, and set it if there may be more events to Pedro> process. With this, there's no need to set it from Pedro> windows_nat_target::wait_for_debug_event_main_thread, so the patch Pedro> also makes us not do it. Looks good, thanks. Approved-By: Tom Tromey Tom