From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id azsEFNsS+WjmJwMAWB0awg (envelope-from ) for ; Wed, 22 Oct 2025 13:22:35 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xDy8pWZQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3F7301E04C; Wed, 22 Oct 2025 13:22:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5F3B51E04C for ; Wed, 22 Oct 2025 13:22:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB1713857C7F for ; Wed, 22 Oct 2025 17:22:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB1713857C7F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xDy8pWZQ Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 2A8E23858019 for ; Wed, 22 Oct 2025 17:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A8E23858019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A8E23858019 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761153697; cv=none; b=jn3FZY+gdx0uhl9uwwJxRkBz3V4YTUHSc4vbN91pDD32LPn1LGK7UFNTT1Pqlox4uTN9ux+DjINijRXX5EWNKWGjcwH6hrRFh0/Kp2RbkTU6y+j6iAd+PlRmXRAFwk5h7zRpLHQpmrhbQsw6vYTZQ4c13K8zo2mB2YBzj30tL2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761153697; c=relaxed/simple; bh=4tDUERkunbuo8im8KCA4xcgRSLH9uI/Xja8VrZJFaa4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qs5VG2UHwWRyH83XVGBE2pSiawxWV58v3xaQmARug8YrxQApBreJ8svd+iNXFoUHxqMbra5wZt0GTucZKgRpl9bNW7jT+Roi/h4I0jzOHMe45IjLg3OOSH2iruot2odp0CERNnh88mkjcaxIxkhAVBaz4i7eumhnvyMzrihqvow= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A8E23858019 Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id BZs9vsBxKjzfwBcWhvhsHe; Wed, 22 Oct 2025 17:21:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BcWUvDoF6EQP9BcWUv8wiP; Wed, 22 Oct 2025 17:21:18 +0000 X-Authority-Analysis: v=2.4 cv=MpNS63ae c=1 sm=1 tr=0 ts=68f9129a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=TQ__qmm939GjHJcYWHUA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/btoD7dKfcXIdwJl33HNqxOcZg7kxUausBLe0uraZz8=; b=xDy8pWZQ12yKd7Pw+g/yiL4m6c mdXZpEGwerWxaUxaKgduCaqCZ+ThfWNX+yDNsnfz9WxiB1JrzaRj71YA0pMmWKWjLM+qPG0f+ADyP WjLoc7OxOviU9l5/Iea1WfuLN; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:55222 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vBcWT-00000000mgV-47GA; Wed, 22 Oct 2025 11:21:18 -0600 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCHv3] gdb: remove attempted type de-duplication when building gdb-index In-Reply-To: <87ldl3c4h4.fsf@redhat.com> (Andrew Burgess's message of "Wed, 22 Oct 2025 16:59:19 +0100") References: <5fb2ed381ab0f96c5057f1644ca67dceebcdf3b7.1760638029.git.aburgess@redhat.com> <87cy6fkltn.fsf@tromey.com> <87ldl3c4h4.fsf@redhat.com> X-Attribution: Tom Date: Wed, 22 Oct 2025 11:21:16 -0600 Message-ID: <874irqlunn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1vBcWT-00000000mgV-47GA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:55222 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfA3xUNp5W9eGBe7jAj0kaMtkYfnxPwC7hWMzaKdTTjmb3Wo6igyG1Few07DObX3Jzstu2R+9Jdkbprb8EOTqpF5h9Zfvdg6gOBy56nrkF/nSrGb04CFO B0QdNzwqf85/jPXW17L8wPjVt0NNhbjo9gNoC03OVbtGj9hoMQg4+8G6JsGunFUYuTJFeGNXVWpmmz6Qr2+JTNe9AYODFXf+dkc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> This also seems like something that could be fixed. For instance >> completion could be done from the index as first pass. Andrew> To be clear, this isn't just a completion issue. The example in PR Andrew> gold/15646 is for 'break namespace_foo::misspelled', where this is also Andrew> going to trigger expansion of many CUs. Andrew> But maybe there's information that we could track better that would Andrew> allow us to only expand a single CU in some cases? For completion I had some thoughts, namely that the only time we need to expand a CU for completion is when completing a C++ function, because I think that's the only case where an index entry and a full symbol should have different names. For the "break prefix::fn" case, maybe if linespec sees that "prefix" is a namespace it could stop the outer search. It might still be an issue if "prefix" is a class since I think (1) linespec may try to set breakpoints in superclass methods (not sure) and (2) different CUs may have different views on a class, like different template method instantiations. However at least (2) is a case of getting what you asked for. Tom