From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XOFEII78cGkXXg4AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 11:19:26 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hViIqVRx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 70FBF1E0AD; Wed, 21 Jan 2026 11:19:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A68D71E08D for ; Wed, 21 Jan 2026 11:19:25 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1EABA4BA9012 for ; Wed, 21 Jan 2026 16:19:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EABA4BA9012 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=hViIqVRx Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D62034BBCDED for ; Wed, 21 Jan 2026 16:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D62034BBCDED Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D62034BBCDED Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769012323; cv=none; b=e6AnwZcpnnkTCYLhFXMU7fBOp7PU9NAKBpHHpJeuIvurUYVnSG5Lav7aB1Yh1/+0U6DAf35IdMh1F3BSy8tDwExXE2IK6DPTdWn201A8/G7b6QLwGRD5l0qWI6Kh69Rd+8rbMZF86cbF5sQWW0Q9X5N1jGP/kU6rB2+5MAekKKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769012323; c=relaxed/simple; bh=mXmBCyxcFd3ZVmQeDrDsM3dY2liVlz280u4I5hjl+yA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ldzDJp283mlOE6JS4BOTvXmjY+/DPIur/Gu8YJlwN6zfocdSZybV0x270XUvraGK+/fQkHAWqb779RC5RfT/XBRg4cth+/p0h2gX1xUofu8BDrM9ftqoZKP6qEGuxVgsKIRfHHq558tEnXySpcSCcz2AJkihZoSITJzbQGCfBAE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D62034BBCDED Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id iSCBv9Sb7ipkCiaunvm9FT; Wed, 21 Jan 2026 16:18:41 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iaunvVATQjAxuiaunvz7vR; Wed, 21 Jan 2026 16:18:41 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=6970fc61 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=L9-cCOitMd2IuvNQRVQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OqKOHipYP3le84PQGd6B+4/ZT0doiGCXpMKPyiQrZgE=; b=hViIqVRxLCsZB4DAhUu+JDEGh6 ZMIBIjMjCUbGDAY0sCGdLRjMhEu71vWdHl77XXwB+7AAAr2R1eFu3ZC2Zk4Zp6jFCfuijkh0/VQGo I06/gG0YA05MQnFGprwh2j0xg; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:60828 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1viaum-00000000UYZ-3cWI; Wed, 21 Jan 2026 09:18:41 -0700 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 11/11] Add aarch64-windows support In-Reply-To: <20260117135448.2666604-11-ssbssa@yahoo.de> (Hannes Domani's message of "Sat, 17 Jan 2026 14:54:34 +0100") References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117135448.2666604-11-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 21 Jan 2026 09:18:39 -0700 Message-ID: <874iof7xcw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1viaum-00000000UYZ-3cWI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:60828 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN9MbFQBiQLG2xjXhAUEWg5lEUAz/ePWJJ99R9voWzwBXNXoE1TTVVS0BdLCQZKooUXNMBRPATF1zIu089mjLMxWeLY54X1anQkRa+Ct1m8vlDCuX5dk ydvXMw1sVh7IRHTH9LfrqGjcJqoqLtRN3fB3yIkNrRC+QjpVbkoZgImgqQBUg8fKvxU09FDqeKLH5/vJJIIMOl3Tk4NMHVA95VM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Hannes" == Hannes Domani writes: Hannes> Changes in v2: Hannes> - added new source files to ALLDEPFILES Hannes> - created NEWS entry Hannes> - removed set_gdbarch_auto_wide_charset and set_gdbarch_long_bit calls Hannes> since these are now done in windows-tdep.c Hannes> - added comments to aarch64_windows_breakpoint and Hannes> set_gdbarch_decr_pc_after_break Hannes> - removed unused 32bit code in Hannes> aarch64_windows_nat_target::fetch_one_register() Hannes> - changed stopped_data_address() to stopped_data_addresses() in Hannes> aarch64_windows_nat_target, and updated stopped_by_watchpoint() Hannes> - initialize windows_process inside INIT_GDB_FILE(aarch64_windows_nat) Thank you. I have a couple of nits but nothing serious. Hannes> +struct aarch64_windows_nat_target final : Hannes> + public aarch64_nat_target I guess I'd stick the ":" on the second line, following the operator rule (even though it's not really an operator). Hannes> +void Hannes> +aarch64_windows_nat_target::initialize_windows_arch (bool attaching) Hannes> +{ Hannes> + memset (&aarch64_windows_process.dr_state, 0, Hannes> + sizeof (aarch64_windows_process.dr_state)); Hannes> + Hannes> + aarch64_windows_process.mappings = aarch64_mappings; Extra space before the '=' here. Ok with these nits fixed. Approved-By: Tom Tromey Tom