From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MdM1OlMC5WlsFCoAWB0awg (envelope-from ) for ; Sun, 19 Apr 2026 12:26:59 -0400 Received: by simark.ca (Postfix, from userid 112) id EB2EB1E04F; Sun, 19 Apr 2026 12:26:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 522111E04F for ; Sun, 19 Apr 2026 12:26:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0C2134C900E9 for ; Sun, 19 Apr 2026 16:26:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C2134C900E9 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 40FBF4BA23F6; Sun, 19 Apr 2026 16:26:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40FBF4BA23F6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40FBF4BA23F6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776615993; cv=none; b=DH+CcTMKV5q4VTGv97xw/PoEwhPj6xERYcplux44V6Swx7C82Pni8vm3xyudaTTA9acByDzy4z6YwV2S+T8+J3K7Adr5m8APabcV6nBLT35A+dR3Rrsw63POhb9Nf8O9q82OBXdSKEBiks4NSAh4zi/zVuBhXbFVWsx4fEK0JaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776615993; c=relaxed/simple; bh=JWoPmwlwf0xbhHPrlb1xS9Ds+0vyu1VdVYHDVtc5i68=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LDyfcBA8KOKgIHE+9wYshiBEe63ecB5NpRHJeKGj/HkYDtZvaFK8pJVCo6gxXKT0mFaQ3gwLn658JXYkGkvtDiaPK1Yxj9ykxwInLORDIvgcIo0eaVdUdpJL5XpBeFYUu3ZQLSH7gSzZiJot9bJl7By6F8RCdAbm5BZk2qevNr8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40FBF4BA23F6 Received: from mop.sam.mop (2.8.3.0.0.0.0.0.0.0.0.0.0.0.0.0.a.5.c.d.c.d.9.1.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:19dc:dc5a::382]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sam) by smtp.gentoo.org (Postfix) with ESMTPSA id D7180341F60; Sun, 19 Apr 2026 16:26:29 +0000 (UTC) From: Sam James To: Sunil Kumar Dora Cc: Kevin Buettner , gdb-patches@sourceware.org, macro@orcam.me.uk, eliz@gnu.org, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca Subject: Re: [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support In-Reply-To: <34d46130-d63f-4248-8ac1-ef8c30305050@windriver.com> Organization: Gentoo References: <20260324164527.1446549-1-sunilkumar.dora@windriver.com> <20260327111515.3adb29a9@f42-zbm-amd> <34d46130-d63f-4248-8ac1-ef8c30305050@windriver.com> User-Agent: mu4e 1.14.0; emacs 31.0.50 Date: Sun, 19 Apr 2026 17:26:26 +0100 Message-ID: <874il6syq5.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --=-=-= Content-Type: text/plain Sunil Kumar Dora writes: > On 3/27/2026 11:45 PM, Kevin Buettner wrote: > > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Tue, 24 Mar 2026 09:45:25 -0700 > sunilkumar.dora@windriver.com wrote: > > From: Sunil Dora > > On musl-based systems exposes BOTHER, so the > Linux-specific custom baud rate path was being compiled. However, > musl's struct termios does not provide the public members c_ispeed > and c_ospeed, causing a build failure. > > This series fixes the build issue at the macro level (patch 1). > It then adds the preferred POSIX cfsetispeed/cfsetospeed path as the > first choice on platforms where the host libc supports arbitrary baud > rates, such as glibc 2.42 and later, GNU Hurd, and potentially other > libc implementations (patch 2). The existing Linux (termios2/BOTHER) > and Darwin (IOSSIOSPEED) paths remain as fallbacks. > > The two patches are independent: > - Patch 1 is a pure build fix with no functional change. > - Patch 2 adds the new POSIX feature on top of the fixed guard. > > set_custom_baudrate_linux is left unchanged. > > Changes since V4: > - Split into two patches, with patch 1 as a pure build fix > and patch 2 adding the POSIX interface. > - Fixed #if guard formatting and added full stop to the > AC_DEFINE description. > - Removed parentheses from function name references in > commit messages and comments. > - Updated NEWS entry to describe which configurations are > affected. > > v4: https://sourceware.org/pipermail/gdb-patches/2026-March/226133.html > v3: https://sourceware.org/pipermail/gdb-patches/2026-March/225952.html > v2: https://sourceware.org/pipermail/gdb-patches/2026-February/225251.html > v1: https://sourceware.org/pipermail/gdb-patches/2026-February/224968.html > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33747 > > > Both parts are approved. Thanks for persevering through the many > requests for changes. > > One thing I noticed - Some error messages in ser-unix.c still use > "Can not" whereas you uniformly (and correctly IMO) use "Cannot". > If you're up for doing a follow-on patch, one which does > s/Can not/Cannot/ on the remaining occurrences would be appreciated. > > Approved-by: Kevin Buettner > > Hi Kevin, > > I just wanted to check in since I don't have commit access. When you have a moment, could you please push the two > patches? I'll push them on your behalf now. > > Also, I'm happy to send a follow-on patch to address the remaining "Can not" -> "Cannot" occurrences in ser-unix.c. > > Thanks, > Sunil Dora --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmnlAjMbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkDFz AQCsL0+MU63zyB2zTQ0pmTomyurm5dcop8VOHHGV1Hap/gD/T+UfzO3tn0fGb60A +lCGDHdtmrpHUK8NW1vwAxQZfgc= =V6JD -----END PGP SIGNATURE----- --=-=-=--