From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id q2DZGB7ODWoRaAoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 11:07:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tHqgDAdo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 53DDC1E098; Wed, 20 May 2026 11:07:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DF96B1E024 for ; Wed, 20 May 2026 11:07:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4435C4B99F43 for ; Wed, 20 May 2026 15:07:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4435C4B99F43 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tHqgDAdo Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id F2F1F4BB5881 for ; Wed, 20 May 2026 15:06:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2F1F4BB5881 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2F1F4BB5881 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779289605; cv=none; b=DLCNy9L+k8mfvd0LFK6PbBSl9o/+WTUNEIfaLnjVdADt1sSDy/8UA/krb++Vv4hVYC0M7WReH172hHsN5Cd7tcEqwyGTYHobyHCpXFXlEYCneiFFY2PDoge1IMOP8V71tC4+opmzNuGKd/k5/dUc80x2KjslSYAyHzoO2kC+hQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779289605; c=relaxed/simple; bh=EA8mqvWAtL4BIem1zOmEMTKBCJklPAOhXJvtESw7gCA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZL+wsz0JZmZ7I22S48lDUk3KhY7WLkFK/9U4bvR+Sev73o3CGX33aNzzili1+vkqO8X+NvIEpTsWtICVaphM/inQpDcxC57gbx6MUF/OauCbDMV3WHpwvYziFZa6hjIpXwvy76f7LhPX8HuMVrdfpUg5iKd511aNqEjkhc4QGhs= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=tHqgDAdo reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2F1F4BB5881 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id PiTzwKmZKjgwePiVOwRl7G; Wed, 20 May 2026 15:06:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id PiVNwUsW8DvkePiVNw9uSc; Wed, 20 May 2026 15:06:42 +0000 X-Authority-Analysis: v=2.4 cv=RaOQC0tv c=1 sm=1 tr=0 ts=6a0dce02 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=7uhWFK8NhvRg8WE4WikA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Yhe7llf6HXPT7dmI9j6iO4if1O8HwTXirOiMGOfRBsY=; b=tHqgDAdoVQr+/BXtCN5dno94uo j4azPW7nBUzl1inqo/p1UKRcFkoxfE9spoTj1iD8u0vvJgARlWBdQJz3u/sInvnPZNNi6x+VtrO6M EaYnEWj/JUygs5KuD09SZ38Or; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:52248 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wPiVN-0000000472X-17QR; Wed, 20 May 2026 09:06:41 -0600 From: Tom Tromey To: Matthieu Longo Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/4] gdb/python: eval_python_command returns result of the evaluation In-Reply-To: <9d2b5df3-1d30-4ce1-93eb-87bb52ad1d0f@arm.com> (Matthieu Longo's message of "Wed, 20 May 2026 11:07:44 +0100") References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-3-matthieu.longo@arm.com> <87cxywipkx.fsf@tromey.com> <87lddfb3ts.fsf@tromey.com> <9d2b5df3-1d30-4ce1-93eb-87bb52ad1d0f@arm.com> X-Attribution: Tom Date: Wed, 20 May 2026 09:06:34 -0600 Message-ID: <874ik2aznp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wPiVN-0000000472X-17QR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:52248 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfA5VLe6Egcccb8BvMESK5qYOnjsQEfgt0jaGAwnujU7lhcKDvZYRpqPmAAQEKX2qmKM0kHToWXz9nceXBp2383IfvJ73zTqPHgaGvaiHHLzSteng9nKe FWfqivmvUAM7WLneN6jcmeM545mEvkx+tS4ZkhWgMV+j7jkh2+EWWEBOLAsFTmOv0QFbcB09KCJj/hnBsRcpgos0H1zsD/sj1Fw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> Should this be == nullptr instead? Matthieu> No, eval_python_command() returns nullptr on failure, otherwise the result of the evaluation. Matthieu> Previously, 0 indicated no errors. Matthieu> If the evaluation works, PyOS_ReadlineFunctionPointer is assigned. Matthieu> So the change looks correct to me. Thanks. This patch is ok then. Approved-By: Tom Tromey Tom