From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HCsNIpiHKWrD5T8AWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 11:49:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EyIVFYth; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 74D761E0A3; Wed, 10 Jun 2026 11:49:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7921E1E070 for ; Wed, 10 Jun 2026 11:49:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC37D4C3188C for ; Wed, 10 Jun 2026 15:49:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC37D4C3188C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EyIVFYth Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 452094BA5439 for ; Wed, 10 Jun 2026 15:48:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 452094BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 452094BA5439 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781106525; cv=none; b=ace390757y5G8c7jmWtpRbNm8Im6uhqCtc9zuBt14cDEgaU1kOcEhqrTT4WmgoSgH1OGKU5zjnJ8ysFCXlA3o/w2C/YqxAkRUBQWlgyH14IVVjSPM1W9cKrQLJGcsEJboby1CTiCmxjh+ZxOfx1wRfnz3Lst+1X2myL2MFJMKwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781106525; c=relaxed/simple; bh=8/mB7lux6hMtVDGV7TLCNP4IcY/CaZsJGWmeQgypnCA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GKSSNfgJzGuG8VsJUtHZAcLJmA49vGUjRibot1b+emf3OzVDeQBohvtDBtpmUxKBZnF3Qh8E3Gniajs2lbCNl1fEToMRYa7hDK80otQHc5y4o6p6NxapLPdcbeKXNG/hgPrAzKLZ06ZG3KTa6kwg07oeICWQRgzdYGLUYdt9VLg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EyIVFYth DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 452094BA5439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781106524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b+9ic2WK3YKJkRg7we6qp0TDEYaQbpyu82AhNzSp15M=; b=EyIVFYthzSpz3xpdvwh+yTTQ1wgudWxRo758ZYTvozwU/Q8UejsCI3lf1ZKjdlqHHO5EYh VB7yT7FTt4SeMBFboVGx5HI4EXgmNU/vmQQm66EDfE1Zq5xtMJIoIgN/NjwQAIoguZlG4y HRlb04UKJHC06TW9Jv0MpBZzTNvQack= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-PEi73wiyMJumDlvi4AmKBg-1; Wed, 10 Jun 2026 11:48:43 -0400 X-MC-Unique: PEi73wiyMJumDlvi4AmKBg-1 X-Mimecast-MFC-AGG-ID: PEi73wiyMJumDlvi4AmKBg_1781106522 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-460129ef947so4196729f8f.1 for ; Wed, 10 Jun 2026 08:48:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781106522; x=1781711322; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b+9ic2WK3YKJkRg7we6qp0TDEYaQbpyu82AhNzSp15M=; b=XPTj55KdeO2BnaUa6WF8u1GCkw9uOswAMMo89Pm1jk367wzpGkNvMduDvZxr0oYvTf xP7iQjcU9DetYdJyyGAE5Om48Y8+5SaebL/9sHNRCVbThTxKCZU+NaR84TgIvC27rYBM i6lwGOYoRGPtehXOk3IbJlY2PBj+7cO7eeKG3oWcGzgrk1IVZzZ/JcfpVar3taqbZRSm ZipNUZgyLrfNEDU/todumJLkLppqlYVtBuK24Ok7L9hIJCQNrg1kLe9LXXW/9JN4Lzf6 zIZUNHKad05nnwA0j2I4OEpb3wHj3QGbxZ9VLkKVYjLxhW7a9+XbYj1KI23EgaHPelEt Tk8Q== X-Forwarded-Encrypted: i=1; AFNElJ9LpEFv5CG+PrO6JW+jBjF7g1Q4Q2f4X8JE4wA/VoDChz0tJuNGCPxhWI38LbewwcZe/8l4a5RvuSPRhQ==@sourceware.org X-Gm-Message-State: AOJu0YybzzxvDRsEmHIUfPRNur3W1bHN06y8LWoaCNs64Vj0mOLsH4mK Q49okPyjgJz5e9e54bvw/9jFddhpkoaauntCHD1H4DDIzjw4v9zJ/iq1qgL/wry0ma3DdnQBR1T po1rOdm0bkzjZR8mQFolPIpzg5A8a0wDCm+3g+L1uWjyZdEC8uGlO/jiuwngrgHg= X-Gm-Gg: Acq92OF48ALjpiKeMsbiav/SXAZlArFgzKbUy5z/NuEcwDaue867OAfgVNI3TxVFNdW kJaMM4gr3Wk6ruDzcj9+Xl4gw0ZZfPm8eeim6KFpo7NHB4t18YVecGaciAwYmIyVNoSz4RXdcnD XnG4tRz/jV7ORMK/nu70sXlG6lo4iq353o2ALhXHCfGqgATWDHyC1gQtpDpD/ju4qYKxOy1lNBY 2Y/fyApnPXDpaI/oWsvjqrh8Lk/nU/ZsZdrSSkqYt2SgkNbDawuxfFTti/KZbJuKohDN/Wm68Kc Cwm2mciq+k2GrLak0C9iHZqtxsWruMvQAto4+8eng+uN012cT0lCL/TYyVz78XK1AQxwcYzBtVI lx7xslHCRZ9RcGjtn/FFWaqCn9JpfbRCueQKg6wj8gCZI0amDcus= X-Received: by 2002:a05:600c:3e0a:b0:490:b724:dbe3 with SMTP id 5b1f17b1804b1-490c25a07c4mr386800995e9.8.1781106521628; Wed, 10 Jun 2026 08:48:41 -0700 (PDT) X-Received: by 2002:a05:600c:3e0a:b0:490:b724:dbe3 with SMTP id 5b1f17b1804b1-490c25a07c4mr386800665e9.8.1781106521136; Wed, 10 Jun 2026 08:48:41 -0700 (PDT) Received: from localhost (19.81.93.209.dyn.plus.net. [209.93.81.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4602cda3651sm61453897f8f.32.2026.06.10.08.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 08:48:40 -0700 (PDT) From: Andrew Burgess To: Mohamed Bouhaouel , gdb-patches@sourceware.org Cc: mohamed.bouhaouel@intel.com, stephan.rohr@intel.com, markus.t.metzger@intel.com Subject: Re: [PATCH 01/11] gdb, record: fix assertion when remote target is set to non-stop In-Reply-To: <20260518183316.127043-2-mohamed.bouhaouel@intel.com> References: <20260518183316.127043-1-mohamed.bouhaouel@intel.com> <20260518183316.127043-2-mohamed.bouhaouel@intel.com> Date: Wed, 10 Jun 2026 16:48:39 +0100 Message-ID: <874ijaqtuw.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nYruXDC81IINNo8k0zqfGqxfC6K8poqjfZQl4GVkUZw_1781106522 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Mohamed Bouhaouel writes: > From: Markus Metzger > > When forcing the remote target to non-stop via 'maint set target-non-stop > on', reverse tests start failing with > > (gdb) .../gdb/remote.c:7561: internal-error: resume: Assertion `scope_ptid == inferior_ptid' failed. > > This is caused by the record-full target doing one additional step after > receiving a single-step trap event. That additional step is done on the > wait ptid instead of on the event ptid. Fix it. > --- > gdb/record-full.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I notice there's no new test here. My guess is that this fixes an issue that will show up in some test once patch #11 is merged. Please could you include the details of which test exposes this issue so it's easy to review this patch. I've had a look at the next couple of patches and I think this same feedback applies to them to. I suspect (but have not checked) this probably applies to patches #1 to #10. Thanks, Andrew > > diff --git a/gdb/record-full.c b/gdb/record-full.c > index 69d2c100e57..fbb45c84931 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -1290,7 +1290,8 @@ record_full_wait_1 (struct target_ops *ops, > "Process record: record_full_wait " > "issuing one more step in the " > "target beneath\n"); > - ops->beneath ()->resume (ptid, step, GDB_SIGNAL_0); > + ops->beneath ()->resume (inferior_ptid, step, > + GDB_SIGNAL_0); > proc_target->commit_resumed_state = true; > proc_target->commit_resumed (); > proc_target->commit_resumed_state = false; > -- > 2.43.0 > > Intel Deutschland GmbH > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928