From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mUYrN53TYmoHyioAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 22:53:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gHjuuu56; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DD2C51E033; Thu, 23 Jul 2026 22:53:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 20A501E033 for ; Thu, 23 Jul 2026 22:53:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F30334BA23CA for ; Fri, 24 Jul 2026 02:53:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F30334BA23CA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gHjuuu56 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 5D1B94BA2E0B for ; Fri, 24 Jul 2026 02:52:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D1B94BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5D1B94BA2E0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784861572; cv=none; b=IsofwXwLo9scPWkK1HC3PRuWi1s68h5D6WMOKpcuHRqKsf0bgwW64JmGYvwFMNLV1xTQKoiheVbuKC+UELPaXZDNCNf6JEVWBXEETnisZ18MDa9KirP+M/knxKnSTZwugURAhpqftmOJpCSpsQY8vseQGojT7vNLqbkO8ndbzhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784861572; c=relaxed/simple; bh=Exxg1cFPJ5igJFZtrwCRsY7ujpRcRhdx1T1SieQeRKg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jrs5sI6MCJXrjZtUhNkqjZSGrw+8o62+KyubOiWklRpNEE79vZ4viW0qjJHqrRdU1FfOsN4jh1F5FLGnFHayvJkeHfuSOcbpNuqRRwjKTjWu+vF8tje3sNuhVrkhLH2/p+nNG6DBd4fjj0Oz2b99WjtO3insD9AyHmO6oP81Yw8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gHjuuu56 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D1B94BA2E0B Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2ceaf8a1265so16625755ad.2 for ; Thu, 23 Jul 2026 19:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784861571; x=1785466371; darn=sourceware.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=e8SE7CZtBUkK3CFa+jeJa4yR0IawkQKQ+8i5yFpQZAk=; b=gHjuuu56imK3mbOGGJCIT/I3EdMR6poYMbmNesee0zx4WUmweSi4osaguU42ec9Hh+ TDLDYSjZ1955DULiugIAX44btgmrDUHVHxoyf/H9HhGKw2RSLsYG+oN0EYCyZhpKZWEw sohrbovevOJMA8h6b8kZyQoN2yTj/sFiVanuBOCpfzFr4/Rz1RrdKOGyoo/vonu6pz9y 9vAMMCqGgWAw83nZYGpFlVXS9PNnYije7IuDQehBZSA2uStaz9pYsNWs3y1ysAaXsqzg jPMxXLdC3uFsEugNkoJLGsZ4Fp7dYQOQFqEHrroG6grT5TvW71kg/yIKbDv5PCieng4X P18w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784861571; x=1785466371; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=e8SE7CZtBUkK3CFa+jeJa4yR0IawkQKQ+8i5yFpQZAk=; b=HCaPhur7dsdlx4/UHknfEK5URcpnjY0t30WCOR1nP7UIq/BIeyZsE9mqNjsxlLoWbb MiQb3y1fz8wNTSuTe1dQ2RrCGRCpDZ4lCO19ocflAXA9JFXpmom6JOH2QEHTZ+kfLO34 rJju+2FqKJzEiE9j5j+NDJwJ+C7ekTo5Erh+iIO05nK2zwVXNN1nMAQw6vbrEhoxQs/P taiW8FDukv89k6uqxpoem6bPNIuJe0qGvs0ZLG78/L1jW2/dDjFgXg/zSqz7uxeWAcQe eRQrd3H3Lu9k/Tu7FO83LsjFZzSAuFDq2zuh72ioHTT66XvwpQtA6Eyivt84ZNJaCmlM QCDA== X-Gm-Message-State: AOJu0YxBHx32keaR+rZFHbi8kWSoF4miXWuJSEmNYCz6bODOAoBNv8xz eAjKl/QXl3V9QZP3X/2aCuwAJdGTP2k8dBZXiKt75/eAyWREgPk+HbnVas9UjDQ0sMg= X-Gm-Gg: AR+sD13cZyvY4jWRr55o0UKvnSvFJadanxFt4tmotlKyKK4hB/gEGzQSF/7VGjQij5j 7ax7FbddNUm40JudNUVc7zLjFmaxjnMmFc74om51bilm2LCq6rEUb5x+3XfMJOJf4NsAp9gdwIY 8UkI6QKy4BtMGS0IwZY+aT3yH4KM6987ouRECRGph+M+p+5ilfxssYfbb7VwaDrVSrcHxdKZ9pi k7XwYzKCienheIf+9J5F3FzP/XuVE+X4D5VMcG6ctHbN38aWI3JqfhRO8e1ixjyl5cUPZ7G6WPE JolyOVsJQTi+kkNDfFV+lQIUh0p5yau479su1ZbjfwX8Sx8ojdJ+Edsjh8PH3liVOP89tf8tAUp x4VDY799l1okNEIvX3aAbeS1HKKP9NK946xqtIcRh4FTOu+9dB1rz3DqFJ+l39oPmXqwp94UO+s z5MxXH6rUFoCs2Zj1il+BpmBE= X-Received: by 2002:a05:6a20:c704:b0:3bf:a7d5:df38 with SMTP id adf61e73a8af0-3c44af771admr6794243637.9.1784861571444; Thu, 23 Jul 2026 19:52:51 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e1bc886sm25379947eec.26.2026.07.23.19.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 19:52:51 -0700 (PDT) From: Thiago Jung Bauermann To: Matthieu Longo Cc: gdb-patches@sourceware.org, Luis Machado , Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey Subject: Re: [PATCH v1 08/10] gdb/linux-tdep: migrate parse_smaps_data to file_reader_t In-Reply-To: (Matthieu Longo's message of "Tue, 14 Jul 2026 09:49:40 +0100") References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-9-matthieu.longo@arm.com> <87v7aozmua.fsf@linaro.org> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Fri, 24 Jul 2026 02:52:48 +0000 Message-ID: <874ihpf69r.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Matthieu Longo writes: > On 09/07/2026 07:41, Thiago Jung Bauermann wrote: >> Matthieu Longo writes: >> >> Suggestion: mention in the commit log that since the previous commit, >> the old variant of parse_smaps_data is unused. >> > What about : > > gdb/linux-tdep: remove legacy parse_smaps_data overload > > Now that all callers use the file_reader_t overload of parse_smaps_data, > the legacy interface taking a raw buffer and filename separately is no > longer needed. > > Fold its implementation into the file_reader_t version and remove the > obsolete wrapper. This also simplifies the implementation by using the > file_reader_t accessors directly. Looks good to me, thanks! -- Thiago (he/him)