From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ydg9IB0SjGogejsAWB0awg (envelope-from ) for ; Mon, 24 Aug 2026 05:42:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ogc9uCq/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A8471E0A3; Mon, 24 Aug 2026 05:42:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D10A01E033 for ; Mon, 24 Aug 2026 05:42:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AD124BA23F4 for ; Mon, 24 Aug 2026 09:42:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AD124BA23F4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ogc9uCq/ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7FF634BA2E37 for ; Mon, 24 Aug 2026 09:42:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FF634BA2E37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FF634BA2E37 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787564545; cv=none; b=kQzdYJlHufn5rttXQJTLG+vtBkb8+R9hu36CrnnC4OJAKFgkffMrPFc6JVo82SH9WmGqV0Yuo3d4Zw1kl3aNI4QZijJwnUVryjuhW9If4gZJi3+6qviUR7xCfrgew0hGwB/lNUtC/ZG/Jbpirw/jxxfpFC4SpQ65Gqb1+kNz0Z0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787564545; c=relaxed/simple; bh=t4/wi5f7hucIo9liZe16gpfVh09EDrE/8c9Q3YwXSEs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LURhxzFqENeFoqVL1MZnyLkJYWK9/z7WoWME0+W6ujkHAFCBkx+GlueiNCXDEevW4Ml25/I96JqcXMS0cKv1er5fFMvdzP3WHswSZ2AhBiyo+lDiomZPqYKBBG+tSeYII+0DNScgGZpJLgHfuwAjA0PzS6lz8FP+yM4UgiLwC4k= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ogc9uCq/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FF634BA2E37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787564545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zr1z6OOG8r8xpS3sq6NSmSLZvni/L1g+hg/CaDkHrBo=; b=Ogc9uCq/vbg4yMQJnVrRFmu3h3pN2TbVhymmG9joGCe0z7xtC7GWi4a+QTVNZjO69vUYCj 1PXaDn0T01CjpG4EZjJ9+2utQFYuwJ1VF+AyAsHxcHxBpTupcuuVHxuF3Q6gfPO5AIfWYz jhknz3tBkgPtqUgpfkyRAbcXRS0l0lg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-NNsozfnTNTS3DfmS_0Yeaw-1; Mon, 24 Aug 2026 05:42:23 -0400 X-MC-Unique: NNsozfnTNTS3DfmS_0Yeaw-1 X-Mimecast-MFC-AGG-ID: NNsozfnTNTS3DfmS_0Yeaw_1787564542 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47fe23b5acdso2626193f8f.0 for ; Mon, 24 Aug 2026 02:42:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787564542; x=1788169342; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Zr1z6OOG8r8xpS3sq6NSmSLZvni/L1g+hg/CaDkHrBo=; b=XqugtZ97k/md8NsnkG8fgQPBsD7Wqas8ujrZuC1A0CcHuee1FCqd/8hKWtsurkVy6C gnKiGVD5+a7uWS2cFYCHKoic4d3t+RxIRz4f91PHdGAsuFoKXPPUbFu3nqfYaIHjNHGX HwYczXeeH2RF2dfpraMiSTmbHtZIM6mLedZnOgqbby2wTr+ajN6rmt3VQ4mY5b/NmHwI /xt4fvhlTpqRovt+Iuj+yRZCkOJDVaDVPzaGLMA9xhP3SxdTgsBDcSluELvpGv5k9G2d 9AZ/O/et+i7NXXYO3SJj5/TB/b2jwbZOzihbYL+51qQNctCnSG/lOQiWECRJFfKfBYMi 6zeA== X-Gm-Message-State: AFuF++nzrFPmQNYUZnwb6kWwtxK2TtswJv3/nwJGrA0bZiEjCi0FjWlk mUztlyThuK2Fo68VKwqMm/vgaZ6mgruzM6UwG+G2aWS93KHGBSGWrpH1NFJ/ia033C+dlM+bAfF KJ5qYNHc/F8aaOuAbYB6QagoEtjoCcxF8DZqgC5g8soJKbqot4OEo0H9ncka4qp5twfTjkqQ= X-Gm-Gg: AR+sD11/Q9V905smexVTabTsullA0GC+cR68x2rUuhf+hwkG6nVu8FBf04FgO7hyMbO zZo/1crh/gsMXl5dtdoMmSfTvzKx7ibtrtVV/b2tGiSess5ZH8VOiiBWPUZ3eTLOyFRdEGHeQp5 UcuWwTa/n1I8kRQdncQYXO6xUigHa71mwr95USmdKhiB0GaItOT/nwB11FMnofeXvRunD5SvDBg Ql778/wf+wxqres+9pz2EtNM14hwBomsWq6ZOcAKVN6dk0ZLPYoJG5IlYYlb4v/2JuIVsSv/w0C CV76j77MvfdURoqsY4H6EiLnXoEm/70V/bWBDmEJqG/MkLznSwDppWlHsL8lJM5n05Vrx6lZO5H 8F72AdIlm6rZNvpSI2lTIM36ofGM= X-Received: by 2002:a5d:6f18:0:b0:482:ac0f:707f with SMTP id ffacd0b85a97d-482c0b55e10mr35314290f8f.1.1787564541900; Mon, 24 Aug 2026 02:42:21 -0700 (PDT) X-Received: by 2002:a5d:6f18:0:b0:482:ac0f:707f with SMTP id ffacd0b85a97d-482c0b55e10mr35314186f8f.1.1787564541487; Mon, 24 Aug 2026 02:42:21 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9c146d0sm7733696f8f.35.2026.08.24.02.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 02:42:21 -0700 (PDT) From: Andrew Burgess To: Rainer Orth , Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Skip gdb.dap/pause.exp on Solaris [PR34548] In-Reply-To: References: <87fr07tupw.fsf@tromey.com> Date: Mon, 24 Aug 2026 10:42:20 +0100 Message-ID: <874igj26tf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y5ulcgJCDugkdrszWLPeavuaD3sDB0kNPZUlpvJBzjQ_1787564542 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Rainer Orth writes: > Hi Tom, > >>>>>>> "Rainer" == Rainer Orth writes: >> >> Rainer> As detailed in PR PR dap/34548, the gdb.dap/pause.exp test runs >> Rainer> indefinitely on Solaris. To allow make check to finish, it needs to be >> Rainer> terminated manually. >> >> Rainer> To avoid this, this patch skips the test. >> >> Rainer> Tested on x86_64-pc-solaris2.11, sparcv9-sun-solaris2.11, and >> Rainer> x86_64-pc-linux-gnu. >> >> Rainer> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34548 >> >> Rainer> Ok for trunk? >> >> This is fine, but in the bug you mentioned other reports about target >> async not working. > > not actually reports, just ca. 100 instances of the > > Asynchronous execution not supported on this target. > > message in the full testsuite log. Some of them already turn the tests > UNSUPPORTED, while others cause the tests to FAIL. > >> So maybe DAP testing should be entirely disabled for Solaris? > > Like just returning 0 from allow_dap_tests on Solaris? Or doing so for > all targets lacking async support? I'd suggest adding: # Return true for targets that support target async, # otherwise return false. proc supports_target_async {} { # ... } then return 0 from allow_dap_tests for any target that returns false from the above. That would seem better than just having a selective fix in the pause.exp file. > > Here's a breakdown of gdb.dap results on Solaris: > > 8 ERROR > 11 FAIL > 713 PASS > 8 PATH > 8 UNRESOLVED > 2 UNSUPPORTED > > I can't tell if it's still useful this way. I haven't checked by a lot of these passes are going to be general boiler plate stuff. If DAP support is known to require target async then my personal feeling is that we'd be better just skipping those tests on Solaris. There's plenty of testing done on other targets where target async is supported. > >> Rainer> This might also be a candidate for the gdb-18 branch. >> >> It's fine by me. > > Thanks. I'll way for approval from a release manager then. It might be worth getting the above changes made first. If you don't have time then let me know and I'll take care of it. Thanks, Andrew