From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pUe2Mfv9tGoKRjwAWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 06:39:55 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cf6E+eVM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ABD0C1E06B; Thu, 24 Sep 2026 06:39:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3C18A1E033 for ; Thu, 24 Sep 2026 06:39:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26BC24BB3BFF for ; Thu, 24 Sep 2026 10:39:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26BC24BB3BFF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cf6E+eVM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 36D214BB3BA6 for ; Thu, 24 Sep 2026 10:39:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36D214BB3BA6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36D214BB3BA6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790246370; cv=none; b=JbUVjidghNw/ZHlMPEEoX1JDsFURFw1oJqmAa8CoGIMPMMb3sXh4Q5Ak7qIuJYtw6sO3GIjBPv9gAPqYDU6b0Ir8jH38IZqgJzcDUEE+sHA12Z3O5ixN+kuT12RVHS2JZuNyFGHm8CB5zezH5SKMT2DOrb9jjcuSyuzEH+1IA1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790246370; c=relaxed/simple; bh=JETfeIxFqnamNEj2VBlLXuaMI3szX9wtY6VrDLFi4to=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wdKZzKlcZBob34K+OoIqz426IzDjFMssUuHlnju3if0MMZdNOEyRpA4AYHCmjDRda7n7BHyVCmApGIF331ORA9Alm0Il1j6XHSrHiZ7qKyJr8jMDg+NcakYNDRzaGKCTIpO/KgyHqHyA9OjflWoOUxCPW/sOseG3uvxyaEHLkLE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cf6E+eVM DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36D214BB3BA6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790246369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=447S8+uB8VBo4Par6wZ8ZRgq5L7Mnr1TSQW0wgBFQVE=; b=cf6E+eVMtpnZlEsL02ZXDH3/WFjbMzvY/EpCAX1O2hyMjJyenOTqkCi+xwQ2izg4TP1ezc +FciUXMSb5+cPCdia691D+mwB0hyMfTJUmxtRhnlenmf+A6pTleCHkVHnvBDnKKZtF7vGD ROhSvx2fUgxs9xM8kwy0vE4Rgk7S5C0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-WfUuDqOvN3em5vKWC5b-zQ-1; Thu, 24 Sep 2026 06:39:28 -0400 X-MC-Unique: WfUuDqOvN3em5vKWC5b-zQ-1 X-Mimecast-MFC-AGG-ID: WfUuDqOvN3em5vKWC5b-zQ_1790246367 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-488773be870so20948f8f.2 for ; Thu, 24 Sep 2026 03:39:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790246367; x=1790851167; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=447S8+uB8VBo4Par6wZ8ZRgq5L7Mnr1TSQW0wgBFQVE=; b=AfANuAlP3114KRhbK24nQg/+FnmNg8f/71vnaM5dK+JfiQTbxYLLVhZilOyD+7qSNW SAWx3+Lr/h38f32/OqK3TREL7J0oqNttVlQFZ3vL81Ca8tMAjIomw0pJ56H73c66qMIG ArBWQYf9Pu7yXwdWc0jAz8Ba4Z572z8Qy1L7pZ5PwntB/taQblGb+Y1qO2Q1qmwiURF6 rDDSbUFDg73Jss9KRVUMf7qN/6c00gw5y9NF93sccVJZfp+wP2LJwyNkcdKQVTTkIuEq S8T0dTNohqMmIgWZI57gLQIl0TzqBZho3Jpu8ZF2Eqria3L0CkVtrL9JsIoAcDb/NPxt fPrw== X-Forwarded-Encrypted: i=1; AKwUvBzYrPm2Zdm2B/hIjPRsSkTFRDF5LOGt44KzY1OSPXQUtqCecPkFBHItMtfzf6b9+S84U4uyYa2ypVCwOQ==@sourceware.org X-Gm-Message-State: AFuF++mvVQZZf56n52cukr6It1bYVKiVtplPqdVd1JGoJ44vFc+ERUyP /FCVrdI8sau6clN3fo+24sT5YhIBBRh3R8nx8Ac1g2y5SBI1opEtvDUC0uJwlqw/oadc5GUMmXU Cv8x9D+iFyO3uu/asghOe6aM12IU4cFK6euRbMGyCoTkZJLzrZgLLdoiFdYey3fax/So+I+I= X-Gm-Gg: AYBFou3Nhm+ZsY8xSoUgWZcfc+Q0L8YU0p4jiF2L5JsGg0pb3Eq6OvMdyZfS+P8g3+N hE8VbHXlkHs4W610T3jHTwIugjiTc2zHziJLtCklnWmGSbjkppHycUg0eyq3NeuHECn5Og8hfui VgZC4AIrfW0j9a/gSRXEg3wzJ2Xpfk2YBCnCbD1K8T1cI4ahBYFHagNdxAWwWG1DQHTgLoqUPbE 77UMeAGfjTzQrmM2TYVh8JqLot2p7o1LryltoiS/BEu9AaVq1bZJ3QJ0CXdL8oLxQpKnaSRiJuj SIBSqxP+ESbYJYnGs0dBYWUrFsh080q/EGgX2PpPW73mcWoxkPPgON92NXbG5eXkB244 X-Received: by 2002:a05:600c:1385:b0:49f:e3f2:6851 with SMTP id 5b1f17b1804b1-49fe66c6150mr32201415e9.8.1790246367078; Thu, 24 Sep 2026 03:39:27 -0700 (PDT) X-Received: by 2002:a05:600c:1385:b0:49f:e3f2:6851 with SMTP id 5b1f17b1804b1-49fe66c6150mr32201105e9.8.1790246366659; Thu, 24 Sep 2026 03:39:26 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fe0c50da7sm83988325e9.3.2026.09.24.03.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 03:39:25 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: resolve class name via DW_AT_signature in cooked index In-Reply-To: <20260924050002.1539783-3-simon.marchi@efficios.com> References: <20260924050002.1539783-3-simon.marchi@efficios.com> Date: Thu, 24 Sep 2026 11:39:24 +0100 Message-ID: <874iff2asj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lns8vzCLmHxTlHI6OM4GPa2xkmDJvEsEQl3Udq7Y3S8_1790246367 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon, Thanks for working on this. This looks great, I have a couple of minor comments. Simon Marchi writes: > From: Andrew Burgess I'd be fine if you wanted to change yourself to be the author, you've put a lot of work into this iteration. But I feel you should at least add a Co-Authored-By tag if nothing else :) > diff --git a/gdb/dwarf2/cooked-index-entry.h b/gdb/dwarf2/cooked-index-entry.h > index 60ea581cbbe5..a2e007b7cf69 100644 > --- a/gdb/dwarf2/cooked-index-entry.h > +++ b/gdb/dwarf2/cooked-index-entry.h > @@ -47,6 +47,8 @@ enum cooked_index_flag_enum : unsigned char > /* True if this is a function that has DW_AT_inline set in a way > that indicates it was inlined. */ > IS_INLINED = 64, > + /* True is m_name.deferred has a value rather than m_name.resolved. */ Typo: 'True IF m_name.deferred ....' > + IS_NAME_DEFERRED = 128, In cooked-index-entry.c you need to update: std::string to_string (cooked_index_flag flags) which converts these flags to strings. > + > +/* See cooked-index.h. */ > + > void > cooked_index::start_canonicalize_names () > { > @@ -124,10 +207,14 @@ cooked_index::start_canonicalize_names () > { > group.add_task ([this, this_shard = shard.get ()] () > { > + complaint_interceptor complaint_handler; > + I think you should add the complaint_interceptor to cooked_index::start_resolve_deferred_parents and cooked_index::start_prune_nameless_entries too. It's not needed in those cases, but it's not needed here either. My reasoning is that adding it is cheap, especially if no complaints are emitted, and it's done in a worker thread, so we notice the impact even less. But, if we ever add a complaint in the future then you need to remember to add the complaint_interceptor, or hope someone catches it during review. Given we're adding the infrastructure now, lets just add the complaint_interceptor to all cases, then we're covered for future growth. With these fixes: Approved-By: Andrew Burgess Thanks, Andrew