From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8c2RI7Vjvmou2SMAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 09:44:21 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DcJPgIM1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 892261E033; Thu, 01 Oct 2026 09:44:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1DFD31E033 for ; Thu, 01 Oct 2026 09:44:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A6504BB5937 for ; Thu, 1 Oct 2026 13:44:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A6504BB5937 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DcJPgIM1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0A8F84BB3B85 for ; Thu, 1 Oct 2026 13:43:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A8F84BB3B85 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A8F84BB3B85 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790862235; cv=none; b=O+ARNEet86KxjYK62zWrEbDeTepHgmBV7sa+N8zVvIVQvuG3vKkKfOjFAMsAfLjf+jI62wCBUs91F9CqObixeBSHGOB3XlwCdchbCFDFUTL9BrJRRV5+QI/r+/8bg/kn4tPKkPqU6wNUJhcqnj4cocYqjKVrz01lGsfTsdxYhYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790862235; c=relaxed/simple; bh=SqWaKNSojn5T3pqF8CgwdVwYc7VGHsNJfBOQCaX0r4U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gQOBCffUMkB5J/qEaoe5Nt+nG3NFHxP/OiikYbIde9+CpWLGqDVMyky3c9PmfH+pqcLNwwp7Xr5QErOM43iMgjrWar8AjsUA+cA6TxwcvirDIt3mzqFxwP9mQRnN12ZoVNAg4YNYRtSU044i55ioZfVRyC19TAC9KS5Ec/COGao= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DcJPgIM1 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A8F84BB3B85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790862234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YooYbqzVfm8Qz7u1VOYmKDJAdeh+4ZmwRetsCwuMa/4=; b=DcJPgIM1cB0Q/XUMYRe4JOpw9dMOWxYLPhSIjDzfhWTZp/x/6WqD4gQh69YDka7h8nqsSd +gTG2k3VBIoEIf15a5Cec17CsdKLvrIYhyC2H9Cs/qBXPdzOEB45DNoPR/2OqLc58qMgGO VGxC6b9vj1Y0WxonfSmUJz+N4hWBTMg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-UU658SuOPOa7nal8BuT0qQ-1; Thu, 01 Oct 2026 09:43:53 -0400 X-MC-Unique: UU658SuOPOa7nal8BuT0qQ-1 X-Mimecast-MFC-AGG-ID: UU658SuOPOa7nal8BuT0qQ_1790862232 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a01c621dc2so10410895e9.2 for ; Thu, 01 Oct 2026 06:43:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790862232; x=1791467032; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YooYbqzVfm8Qz7u1VOYmKDJAdeh+4ZmwRetsCwuMa/4=; b=z5wnExEWfaDqePaiKQWvv+x17uzkrdV/TV4CYKriP9nGQf3ZqNEtbewYf3XknaE6pE z1OQLtjJUJNQuUR4hp5qUSXQUr1o+WQecZMNY7RxlzlMKDzre7ZoveOJ0jY8X/2+pAAK 3w8OaQ1mnAynNyWzJ+00qQWrIGFTKYHHmfVCq4uHopR6o96srkCNF78uEmOR9O/GldHx 7FTANSU8qdqlxb0ZQNybLvRCZR9fyIVURxZnGy240eiAZ6EctWXqpNAVhnRMHne1B+1E L9jZIWLhyt2EoIlPD7mAcfYduBky9UzQrHllsOHivSotag6jVwywrfNYYhqqq3DGUr0n Iqag== X-Forwarded-Encrypted: i=1; AKwUvBxQiOYHqro/F8OjIK0znpMgteGAwtheyHwPfi5305Y/4e3Bt5Y4fBHStfPFefPAerJk7/ew3WaKkViedA==@sourceware.org X-Gm-Message-State: AFuF++lY5fsfCk1fM47AM2u8rmSzy2YJGGo2fyIlU2wSvIW2gBhEiUCc 4r6W5SNteWWsGgqYa+JKT7vMIAHEs4UkANFxL2qOz0NPew6nGb5Cgdc95dgsNlCONgMFV8opYit jQC4udlnNA/dnoPWZEqFdUjG6pT+8HabVJHChdmA6E5E5Ii5WPxYbuN6G+1WO0pY= X-Gm-Gg: AYBFou3TjdapWfMHIy4Sa+c5wJDWgeUzXY/tj4cYL6oxoDJHWOnheYWJ3MponknmJt3 SQSpp6ye+RrVjsNo4YDbOl+lmdTapS0UnUTPCzl3fcsQDX0gu0Yn7OLQJg0QOa/e4/3ju8aMOWf NTV3j8fVjuLJHfQeDdWLTnQivzePpEi8WanrKK12r4I4TVxNOtCMpsia8+kUv7f4/2Czc8X++ft zSL5ewAvm93KuR2P0iwlWiVytEdTVTA31ygNQU/jlTRpQCPWUM/Dgm9AtpYe1Ogb5rKrlW2QQpT 9u2DSMH0RzMy7sw59jgR7sWm5nqIV8Xe0JmLK4rwfo0L4pY7dHPFRmjHV4SfhsPBz69f X-Received: by 2002:a05:600c:4514:b0:49f:ffed:2cb with SMTP id 5b1f17b1804b1-4a01aff3298mr82037095e9.6.1790862231622; Thu, 01 Oct 2026 06:43:51 -0700 (PDT) X-Received: by 2002:a05:600c:4514:b0:49f:ffed:2cb with SMTP id 5b1f17b1804b1-4a01aff3298mr82036835e9.6.1790862231152; Thu, 01 Oct 2026 06:43:51 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01f947898sm74794645e9.10.2026.10.01.06.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 06:43:50 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 04/11] gdb: use compile_symbol_search_regex in stack.c In-Reply-To: <20261001020952.698419-5-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-5-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 14:43:49 +0100 Message-ID: <874if5zgbu.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y83UdFz5KJXrNZjry0n9M84BcfBBhAgogJm9jgRX2ns_1790862232 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > prepare_reg in stack.c does the same thing as compile_symbol_search_regex > in symtab.c, but with an awkward output parameter. Expose > compile_symbol_search_regex in symtab.h and use it instead of prepare_reg. > > Since compiled_regex is not movable, the optionals in > print_variable_and_value_data must be initialized directly from the > return value of compile_symbol_search_regex. Add a constructor to > print_variable_and_value_data to do so. Make the constructor initialize > the other fields as well, instead of assigning them after construction. LGTM. Approved-By: Andrew Burgess Thanks, Andrew