From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19407 invoked by alias); 26 Jun 2002 05:12:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19389 invoked from network); 26 Jun 2002 05:12:45 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 26 Jun 2002 05:12:45 -0000 Received: from fleche.redhat.com (ta0193.peakpeak.com [204.144.244.193] (may be forged)) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id XAA09707 for ; Tue, 25 Jun 2002 23:12:42 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id 1C9F64F80AA; Tue, 25 Jun 2002 23:25:46 -0600 (MDT) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: add_setshow_cmd_full References: <878z53dqr9.fsf@fleche.redhat.com> <3D192849.3080904@cygnus.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: TONY RANDALL! Is YOUR life a PATIO of FUN?? Date: Tue, 25 Jun 2002 22:12:00 -0000 In-Reply-To: <3D192849.3080904@cygnus.com> Message-ID: <873cvahaqt.fsf@fleche.redhat.com> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-06/txt/msg00528.txt.bz2 >>>>> "Andrew" == Andrew Cagney writes: Andrew> Please be careful to configure GDB with Andrew> --enable-gdb-build-warnings=,-Werror so that it is compiled Andrew> with the -Werror flag. Thanks for catching this. I'm rebuilding with that right now; I wired it into my standard build script so I won't make this mistake again. Andrew> Don't forget to remove they stray declaration: >> +extern struct cmd_list_element *add_setshow_cmd (char *name, >> + enum command_class class, >> + var_types var_type, void *var, >> + char *set_doc, char *show_doc, Andrew> from the change. That declaration is part of the change, since I wanted to make add_setshow_cmd public, and add add_setshow_cmd_full as well. The latter is only used in a few places. Would you prefer I use add_setshow_cmd_full everywhere, and just have 90% of the calls have `NULL, NULL' at the end? I can do that... Tom