From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13452 invoked by alias); 17 May 2012 01:56:39 -0000 Received: (qmail 13227 invoked by uid 22791); 17 May 2012 01:56:38 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 May 2012 01:56:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4H1uK6C032691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 21:56:21 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4H1uJbc015808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 16 May 2012 21:56:20 -0400 From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] dynamic printf References: <4FA8BC97.2000801@earthlink.net> <4FA8D049.109@codesourcery.com> <4FB12A8E.7040905@earthlink.net> <87ipfvop8i.fsf@fleche.redhat.com> <4FB41216.2080508@earthlink.net> <4FB4137C.6000107@redhat.com> <4FB4293B.9030303@earthlink.net> Date: Thu, 17 May 2012 01:56:00 -0000 In-Reply-To: <4FB4293B.9030303@earthlink.net> (Stan Shebs's message of "Wed, 16 May 2012 15:24:59 -0700") Message-ID: <87396zmuyk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00645.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> Basically if you set bs->stop to 0, command lists don't get run. It's Stan> a little convoluted, because the code does go into bpstat_do_actions, Stan> but nothing happens there because the copy of b->commands to Stan> bs-> commands in bpstat_stop_status only happens if bs->stop. Stan> That's why I'm thinking of a special command / pseudo-command for the Stan> command list; we don't necessarily want to say that we haven't Stan> stopped, because that meaning is typically reserved for "yes we hit Stan> the trap, but pretend it never happened". I think this would be a good idea in the context of a wider examination of other changes like this that are desirable or needed. It seems to me that there are some other ones in bugzilla. In this particular case, though, I think you could do it by just having the 'printf' invocation not be 'commands' stuck onto a breakpoint, but instead a per-dprintf method that is run at the appropriate moment, a la the Python 'Breakpoint.stop' method. Tom