From: Tom Tromey <tromey@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC] register_to_value/value_to_register arguments?
Date: Tue, 12 Jun 2012 15:32:00 -0000 [thread overview]
Message-ID: <8739607dhb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1206110958250.23962@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Mon, 11 Jun 2012 10:36:30 +0100")
>>>>> "Maciej" == Maciej W Rozycki <macro@codesourcery.com> writes:
Maciej> However this rises a question: it is relatively expensive to
Maciej> retrieve gdbarch from frame, most target implementations of
Maciej> these methods need it and it is already readily available to the
Maciej> caller (retrieved from the very frame) -- wouldn't it therefore
Maciej> make sense to pass it along frame?
It seems to me that the frame's arch is cached, so retrieving it is only
expensive the first time. Given that, the current approach is clearer
and safer, since there's no possibility of arguments being out of sync.
Tom
prev parent reply other threads:[~2012-06-12 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 9:37 Maciej W. Rozycki
2012-06-11 16:13 ` Eli Zaretskii
2012-06-12 15:32 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739607dhb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox