From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25057 invoked by alias); 23 Jul 2012 14:52:14 -0000 Received: (qmail 25045 invoked by uid 22791); 23 Jul 2012 14:52:13 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 14:51:58 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NEpve8007386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 10:51:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6NEpuud003548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 10:51:56 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <877gtzxyck.fsf@fleche.redhat.com> <87sjcmv16h.fsf@fleche.redhat.com> <20120723085355.GA29593@host2.jankratochvil.net> Date: Mon, 23 Jul 2012 14:52:00 -0000 In-Reply-To: <20120723085355.GA29593@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 23 Jul 2012 10:53:55 +0200") Message-ID: <87394isf77.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00448.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Tom> This changes allocate_objfile to acquire a reference to the BFD, Tom> rather than steal a reference. Then it changes all callers, direct or Tom> indirect, to follow. Jan> map_vmap still steals a reference. I'll investigate. One thing I noticed is that bfd_openr_next_archived_file doesn't document who owns the resulting BFD. Must one close it? Or is it closed when the parent BFD is closed? I think the latter; or at least, if not the latter then the caching mechanism in bfd/archive.c is badly broken. Anyway, whatever bugs exist here are latent ones already in gdb. Tom> I'm still undecided as to whether this patch is an improvement. I Tom> think it does fix a couple of obscure latent memory leaks. Jan> I find the code the only way "how it should be" now. Ok. I'm going to put those in. Tom