From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15632 invoked by alias); 9 Nov 2012 19:13:34 -0000 Received: (qmail 15558 invoked by uid 22791); 9 Nov 2012 19:13:33 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 19:13:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA9JDRHA028213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Nov 2012 14:13:27 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA9JDQcT012510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 9 Nov 2012 14:13:26 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: handle "MiniDebuginfo" section References: <87wqxuel5k.fsf@fleche.redhat.com> <20121109182316.GQ5103@adacore.com> Date: Fri, 09 Nov 2012 19:13:00 -0000 In-Reply-To: <20121109182316.GQ5103@adacore.com> (Joel Brobecker's message of "Fri, 9 Nov 2012 10:23:17 -0800") Message-ID: <87390iegix.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00261.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> To avoid the #ifdef HAVE_LZMA, I might even provide two versions of the Joel> file, one with the real implementation, and one with the phony one, and Joel> have the configure choose which one to link in. This isn't what we've Joel> been doing in the past (iconv, python), so to be taken with a grain of Joel> salt. I think it'll make the code a little easier to navigate, however. To me this seems like a lot of work for a single function. And, it doesn't make the code less complicated -- the "#if" is still there, just in configure and Makefile.in rather than in the C. I tend to find the C code more readable than those, which is something I like about the current approach. Tom