From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101432-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31526 invoked by alias); 13 May 2013 14:58:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31511 invoked by uid 89); 13 May 2013 14:58:33 -0000
X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 14:58:32 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4DEwUDB028639	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 13 May 2013 10:58:30 -0400
Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4DEwT1B017915	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 13 May 2013 10:58:30 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 14/40] fix two buglets in breakpoint.c
References: <cover.1368124285.git.tromey@redhat.com>	<9950c2e4c9891c1b716d6c6d32107ddd7e97c5a5.1368124285.git.tromey@redhat.com>	<51905107.5090107@codesourcery.com>
Date: Mon, 13 May 2013 14:58:00 -0000
In-Reply-To: <51905107.5090107@codesourcery.com> (Yao Qi's message of "Mon, 13	May 2013 10:33:43 +0800")
Message-ID: <8738trdizv.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00438.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

>> @@ -5814,7 +5814,10 @@ output_thread_groups (struct ui_out *uiout,
>> /* For backward compatibility, don't display inferiors in CLI unless
>> there are several.  Always display them for MI. */
>> if (!is_mi && mi_only)
>> -    return;
>> +    {
>> +      do_cleanups (back_to);
>> +      return;
>> +    }

Yao> A nit here, we may call 'make_cleanup_ui_out_list_begin_end' after
Yao> this condition checking, so we don't need 'do_cleanups' here.

That isn't what I see in trunk:

static void
output_thread_groups (struct ui_out *uiout,
		      const char *field_name,
		      VEC(int) *inf_num,
		      int mi_only)
{
  struct cleanup *back_to = make_cleanup_ui_out_list_begin_end (uiout,
								field_name);
  int is_mi = ui_out_is_mi_like_p (uiout);
  int inf;
  int i;

  /* For backward compatibility, don't display inferiors in CLI unless
     there are several.  Always display them for MI. */
  if (!is_mi && mi_only)
    return;


That "return" leaves a cleanup dangling.

Tom