From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6159 invoked by alias); 25 Jul 2013 15:20:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6149 invoked by uid 89); 25 Jul 2013 15:20:07 -0000 X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Jul 2013 15:20:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6PFJwTw006936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Jul 2013 11:19:59 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6PFJvG1002455 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 25 Jul 2013 11:19:58 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patchv2 2/2] Fix CTRL-C for remote.c (PR remote/15297) References: <20130630181110.GB29548@host2.jankratochvil.net> Date: Thu, 25 Jul 2013 15:20:00 -0000 In-Reply-To: <20130630181110.GB29548@host2.jankratochvil.net> (Jan Kratochvil's message of "Sun, 30 Jun 2013 20:11:10 +0200") Message-ID: <8738r2wtsy.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00616.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Primarily this patch removes some heavy functions from the signal Jan> handlers as signal handlers can call only few signal-safe functions Jan> according to POSIX. Currently with "set debug remote 1" CTRL-C Jan> typically locks up on malloc where SIGINT handler interrupted also Jan> malloc. I read through this patch and it made sense, at least as far as I could understand it. It's a tricky area and without redoing the research you did I think it is reasonably hard to critique. Jan> The testcase does not work perfectly for target-async + all-stop, Jan> it is not being tested. I did not find it a commonly used mode and Jan> it may be fixed in a different/additional patch. It works in Jan> general but not in 100% cases. Can you characterize the failure modes? Or will I see it if I add a target-async+non-stop case to your new .exp? I have a series here to always enable target-async, which I plan to submit soon. I'd like to understand this more so I can fix up my series. Tom