From: Tom Tromey <tromey@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] move gdbarch object from objfile to per-BFD
Date: Mon, 05 Aug 2013 20:12:00 -0000 [thread overview]
Message-ID: <8738qn99sg.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201308051922.r75JMD4p020143@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Mon, 5 Aug 2013 21:22:13 +0200 (CEST)")
>> I can add it. The reason I did not is that, for whatever reason,
>> objfiles have not historically used accessors. So, I preserved the
>> status quo in this respect.
Mark> Merely a suggestion. If you considered it and decided against it
Mark> that's fine with me.
I'm not sure why, but even though the patch changed get_objfile_arch, I
failed to think of that as an accessor. Weird; but I suppose since it
doesn't follow the usual gdb macro style. Anyway, I'll shortly send an
updated patch that uses get_objfile_arch at all the spots that read the
field. I left the writers alone, as there aren't many and we shouldn't
encourage more.
Tom
next prev parent reply other threads:[~2013-08-05 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 17:56 Tom Tromey
2013-08-05 18:11 ` Mark Kettenis
2013-08-05 19:13 ` Tom Tromey
2013-08-05 19:22 ` Mark Kettenis
2013-08-05 20:12 ` Tom Tromey [this message]
2013-08-05 20:29 Tom Tromey
2013-08-20 15:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738qn99sg.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox