Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix c++/16597 (crash when inspecting lambda expression variables)
Date: Thu, 10 Apr 2014 16:58:00 -0000	[thread overview]
Message-ID: <8738hlqfyw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <532C7A56.8010201@redhat.com> (Keith Seitz's message of "Fri, 21	Mar 2014 10:43:50 -0700")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> That was the easy part. The not-so-easy/questionable part is the test
Keith> case, which uses the (assembler) output of the compiler to run
Keith> against. Writing by hand is very time-consuming and tricky, because we
Keith> must be stopped inside the lambda function in order to trigger the
Keith> bug.

Keith> In any case, I thought I would submit this and see if anyone had any
Keith> better ideas.

I think it's fine to do this.

In the past we've done two additional things that make it slightly nicer.

First, we've checked in the original source file as a separate file, I
think along with a note in the .exp about it.  This approach lets you
avoid this:

Keith> +# WARNING: This is hard-coded from the original source file! This
Keith> +# breakpoint should be set inside the lambda in A::doit().

... since you can refer to comments in the original source file IIRC.


Second, I think we've edited the compilation directory in the .S file,
and maybe other little details as well (I had to edit the files to avoid
'main' for some reason I cannot remember):

Keith> +.Linfo_string2:
Keith> +	.asciz	 "/home/keiths/tmp/16597"

You can easily find some examples in gdb.dwarf2, just follow one of
those.

Tom


  reply	other threads:[~2014-04-10 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 17:43 Keith Seitz
2014-04-10 16:58 ` Tom Tromey [this message]
2014-04-15 18:06   ` Keith Seitz
2014-04-16 20:33     ` Tom Tromey
2014-04-16 21:18       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738hlqfyw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox