From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1233 invoked by alias); 21 Nov 2014 13:37:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1193 invoked by uid 89); 21 Nov 2014 13:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Nov 2014 13:37:18 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1XroOh-0001a3-16 from Yao_Qi@mentor.com ; Fri, 21 Nov 2014 05:37:15 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.181.6; Fri, 21 Nov 2014 05:37:14 -0800 From: Yao Qi To: Patrick Palka CC: Subject: Re: [PATCH 1/2] Fix C++ virtual method pointer resolution References: <1411355243-10812-1-git-send-email-patrick@parcs.ath.cx> <87k32og51t.fsf@codesourcery.com> Date: Fri, 21 Nov 2014 13:37:00 -0000 In-Reply-To: (Patrick Palka's message of "Fri, 21 Nov 2014 07:40:41 -0500") Message-ID: <87389cfze2.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00518.txt.bz2 Patrick Palka writes: >>> +get_debug_format >>> + >>> +if ![test_debug_format "DWARF 2"] { >>> + return 0 >>> +} >> >> Why do we need to check test_debug_format here? > > Because GDB only supports C++ method pointers with the DWARF debug > format. So I'd assume that this test would fail for non-DWARF. I am not aware of this, any details? If GDB doesn't support C++ method pointers with non-DWARF, we should kfail or xfail it in the test. See gdb.cp/m-static.exp. --=20 Yao (=E9=BD=90=E5=B0=A7)