Re: [PATCH][SIM] Add RXv2 simulation

Mike Frysinger
2015-04-08T03:09:56Z

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On 07 Apr 2015 15:00, Yoshinori Sato wrote:
> This patches added new instructions simulation for RX archtecture.

please add some tests. if you look in sim/testsuite/sim/, you should be able to
copy over something simple like mcore and then write a few basic .s files to
test the new insns.

just style comments otherwise -- i'm not familiar with the RX ISA

> + tprintf("sqrt(%g) = %g\n", da, sqrt(da));

all calls need a space before the (
tprintf ("sqrt(%g) = %g\n", da, sqrt (da));

this comes up a few times in your patch

> + /* Less than 0.49999 */

GNU style comments have a period at the end followed by two spaces:
/* Less than 0.49999. */

this comes up a few times in your patch

> + whole_bits ++;

no space before the ++ operator

this comes up a few times in your patch

> + while (! (whole_bits & 0x80000000UL))

no space after the !

> + if (tag) { printf (tag); tag = 0; }

i guess not really a new problem, but you're changing this code so you might as
well fix it, but this should not be one line
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]