From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130291 invoked by alias); 26 Jul 2016 13:18:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130281 invoked by uid 89); 26 Jul 2016 13:18:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 26 Jul 2016 13:18:38 +0000 Received: (qmail 26925 invoked by uid 0); 26 Jul 2016 13:18:36 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy9.mail.unifiedlayer.com with SMTP; 26 Jul 2016 13:18:36 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id PRJW1t0032f2jeq01RJZcU; Tue, 26 Jul 2016 07:18:34 -0600 X-Authority-Analysis: v=2.1 cv=KaJB72oD c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=C6ZbYQPAFpEA:10 a=cAmyUtKerLwA:10 a=20KFwNOVAAAA:8 a=rHId_jCNFCvcFlR2C50A:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from [75.171.160.169] (port=52846 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bS2Fj-0000Xg-ML; Tue, 26 Jul 2016 07:18:31 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Yao Qi , "gdb-patches\@sourceware.org" Subject: Re: [RFA] PR python/18565 - make Frame.function work for inline frames References: <1466439050-11330-1-git-send-email-tom@tromey.com> <86ziqfq6sz.fsf@gmail.com> <8737o5kqtv.fsf@tromey.com> <87bn1lu5h9.fsf@tromey.com> <5ab877f8-9e39-6e02-2ece-46fcbcdacc0a@redhat.com> Date: Tue, 26 Jul 2016 13:18:00 -0000 In-Reply-To: <5ab877f8-9e39-6e02-2ece-46fcbcdacc0a@redhat.com> (Pedro Alves's message of "Tue, 26 Jul 2016 12:14:23 +0100") Message-ID: <8737mwtu5a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.160.169 authed with tom+tromey.com} X-Exim-ID: 1bS2Fj-0000Xg-ML X-Source-Sender: (pokyo) [75.171.160.169]:52846 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-07/txt/msg00345.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Yet another approach would be to push the xstrdup call to after the Pedro> cp_remove_params call, and remove the xfree call, something like: Yeah. Pedro> In any case, IMO this would be the subject of a separate patch. Let me recommend accepting the original patch; and I will write a new patch to fix this. Tom