From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119258 invoked by alias); 13 Dec 2016 13:50:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118009 invoked by uid 89); 13 Dec 2016 13:50:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=initializing X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 13 Dec 2016 13:49:54 +0000 Received: (qmail 10569 invoked by uid 0); 13 Dec 2016 13:49:53 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy4.mail.unifiedlayer.com with SMTP; 13 Dec 2016 13:49:53 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id KRpq1u00S2f2jeq01RptHo; Tue, 13 Dec 2016 06:49:53 -0700 X-Authority-Analysis: v=2.1 cv=DKocvU9b c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=NekjJwFlhSD6vITk-D4A:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 70-58-1-248.hlrn.qwest.net ([70.58.1.248]:37480 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cGnSo-0004PP-BE; Tue, 13 Dec 2016 06:49:50 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 8/8] Add constructor and destructor to demangle_parse_info References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-9-git-send-email-tom@tromey.com> Date: Tue, 13 Dec 2016 13:50:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 2 Dec 2016 15:04:15 +0000") Message-ID: <8737hsey6b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cGnSo-0004PP-BE X-Source-Sender: 70-58-1-248.hlrn.qwest.net (bapiya) [70.58.1.248]:37480 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00291.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> When initializing a unique_ptr from a function that returns a Pedro> unique_ptr already, IMO, using = reads a little better Pedro> over ()s, like: Pedro> std::unique_ptr info Pedro> = cp_demangled_name_to_comp (demangled_name, NULL); Pedro> I.e., kind of like how you'd call make_unique with '=' instead Pedro> of Pedro> unique_ptr foo (make_unique()); Pedro> which I've never seen. Pedro> I wonder whether that's just me? I don't really have a preference either way. I made this change. >> + demangle_parse_info (); >> + >> + ~demangle_parse_info (); Pedro> Put these before the data fields. Done. Tom