From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58053 invoked by alias); 12 Apr 2017 15:05:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57335 invoked by uid 89); 12 Apr 2017 15:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy10.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 15:05:27 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id AE406140CC9 for ; Wed, 12 Apr 2017 08:32:57 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 7SYu1v0182f2jeq01SYx01; Wed, 12 Apr 2017 08:32:57 -0600 X-Authority-Analysis: v=2.2 cv=VKStp5HX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=20KFwNOVAAAA:8 a=QUwS346FTDYc8gagpIAA:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:56282 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cyJKI-0007dd-CW; Wed, 12 Apr 2017 08:32:54 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 06/17] Remove cleanup_iconv References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-7-tom@tromey.com> <4dc59bfe-8129-03c6-4e47-0c246986f388@redhat.com> Date: Wed, 12 Apr 2017 15:05:00 -0000 In-Reply-To: <4dc59bfe-8129-03c6-4e47-0c246986f388@redhat.com> (Pedro Alves's message of "Wed, 12 Apr 2017 12:19:54 +0100") Message-ID: <8737dd7l2m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cyJKI-0007dd-CW X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:56282 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00344.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I find the inversion of the order of "from" and "to" potentially Pedro> confusing/misleading, given this is a "wrapper" class. Is there a Pedro> rationale behind the swap? It mirrors the call to convert_between_encodings, but I agree with your critique, so I've changed it. Tom