From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116291 invoked by alias); 2 May 2017 19:28:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116277 invoked by uid 89); 2 May 2017 19:28:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 19:28:34 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C74D646297; Tue, 2 May 2017 19:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C74D646297 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C74D646297 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1543271D50; Tue, 2 May 2017 19:28:34 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Pedro Alves , John Baldwin Subject: Re: [PATCH] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) References: <20170425202309.15771-1-sergiodj@redhat.com> X-URL: https://sergiodj.net Date: Tue, 02 May 2017 19:28:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 01 May 2017 22:44:39 -0400") Message-ID: <8737cngise.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00027.txt.bz2 On Monday, May 01 2017, Simon Marchi wrote: >> +++ b/gdb/configure.nat >> @@ -0,0 +1,591 @@ >> +# Copyright (C) 2013-2017 Free Software Foundation, Inc. >> +# >> +# This file is part of GDB. >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program. If not, see >> . >> + >> +# Variables defined here: >> +# >> +# NAT_FILE >> +# NATDEPFILES >> +# NAT_CDEPS >> +# LOADLIBES >> +# MH_CFLAGS >> +# XM_CLIBS >> +# NAT_GENERATED_FILES >> +# HAVE_NATIVE_GCORE_HOST >> +# NAT_EXTRA_FRAGS_FILE > > Could you document (if you know it) what each variable does? Sure. Here's what I know what them. What do you think? # Variables defined here: # # NAT_FILE - The header file with definitions for this host # # NATDEPFILES - The depfiles to be compiled for this host # # NAT_CDEPS - Dynamic symbols to be exported for libthread_db # # LOADLIBES - Libraries that will be linked against GDB for this host # # MH_CFLAGS - Additional CFLAGS for this host # # XM_CLIBS - Host-dependent libs to be linked against GDB. # # NAT_GENERATED_FILES - Generated files by this host # # HAVE_NATIVE_GCORE_HOST - # # NAT_EXTRA_FRAGS_FILE - File containing extra fragments of Makefile # that will be used by this host. # # Notes: # # - To avoid shell expansion of variables, declare them with single # quotes. # # - NAT_EXTRA_FRAGS_FILE should contain the full path of the file. >> +# - To avoid shell expansion of variables, declare them with single >> +# quotes. >> +# >> +# - NAT_EXTRA_FRAGS_FILE should contain the full path of the file. >> + >> +case ${gdb_host_cpu} in >> + aarch64) >> + case ${gdb_host} in >> + linux) >> + # Host: AArch64 based machine running GNU/Linux >> + NAT_FILE='config/nm-linux.h' >> + NATDEPFILES='inf-ptrace.o fork-child.o aarch64-linux-nat.o >> aarch32-linux-nat.o \ >> + proc-service.o linux-thread-db.o linux-nat.o linux-fork.o \ >> + linux-procfs.o linux-ptrace.o linux-osdata.o linux-waitpid.o \ >> + linux-personality.o linux-namespaces.o aarch64-linux-hw-point.o \ >> + aarch64-linux.o' > > IMO, the interest of having all of this in a single file is to be able > to factor out common things. A lot of NATDEPFILES are repeated Would > it be possible to have a switch on ${gdb_host} at the top level, and > specify all the files specific to OSes but machine-agnostic? For > example, fork-child.o and inf-ptrace.o probably appear in all the > linux ports. Fair point. I will address what you and Jon mentioned, and resubmit the patch with the modifications. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/