Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH RFC 3/5] Make index reading functions more modular
Date: Thu, 10 May 2018 21:02:00 -0000	[thread overview]
Message-ID: <8736yz1bbd.fsf@tromey.com> (raw)
In-Reply-To: <1525901216-15031-4-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Wed, 9 May 2018 17:26:54 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> The read_gdb_index_from_section and read_debug_names_from_section
Simon> functions read the index content, as their names state, from sections of
Simon> object files.  A following patch will make it possible to read index
Simon> content from standalone files.

Simon> This patch therefore decouples the code that reads the index content
Simon> from object file sections from the code that processes that content.
Simon> Functions dwarf2_read_gdb_index and dwarf2_read_debug_names receive
Simon> callbacks that are responsible for providing the index contents (for
Simon> both the main file and the potential dwz file).

This callback style makes the code harder to read and understand; but
other than that this seems fine.

Tom


  reply	other threads:[~2018-05-10 20:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 21:57 [PATCH RFC 0/5] Add a DWARF index cache Simon Marchi
2018-05-09 21:27 ` [PATCH RFC 1/5] Rename some functions, index -> gdb_index Simon Marchi
2018-05-10 20:40   ` Tom Tromey
2018-06-12  2:03     ` Simon Marchi
2018-05-09 21:27 ` [PATCH RFC 0/5] Add a DWARF index cache Simon Marchi
2018-05-09 21:27 ` [PATCH RFC 5/5] Add " Simon Marchi
2018-05-10 22:24   ` Tom Tromey
2018-07-09 20:56     ` Simon Marchi
2018-05-09 21:27 ` [PATCH RFC 4/5] Introduce scoped_mmapped_file Simon Marchi
2018-05-10 21:04   ` Tom Tromey
2018-05-10 21:27     ` Simon Marchi
2018-05-12 15:49       ` Tom Tromey
2018-06-13  1:36       ` Simon Marchi
2018-05-09 21:27 ` [PATCH RFC 3/5] Make index reading functions more modular Simon Marchi
2018-05-10 21:02   ` Tom Tromey [this message]
2018-05-10 21:18     ` Simon Marchi
2018-05-09 23:08 ` [PATCH RFC 2/5] Remove mapped_index::total_size Simon Marchi
2018-05-09 21:27   ` Simon Marchi
2018-05-10 20:54   ` Tom Tromey
2018-05-18 20:26     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736yz1bbd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox