From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81940 invoked by alias); 18 May 2018 00:25:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81907 invoked by uid 89); 18 May 2018 00:25:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 00:25:46 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BAAB402310A; Fri, 18 May 2018 00:25:44 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 268052024CBC; Fri, 18 May 2018 00:25:43 +0000 (UTC) From: Sergio Durigan Junior To: Joel Brobecker Cc: Keith Seitz , Tom Tromey , gdb-patches@sourceware.org, Pedro Alves Subject: Re: possible fix for PR symtab/23010 References: <87po34kzxh.fsf@tromey.com> <20180430224454.wrnu4u45o5gukrxs@adacore.com> <20180507171309.f4yjprji4g3deubw@adacore.com> Date: Fri, 18 May 2018 01:22:00 -0000 In-Reply-To: <20180507171309.f4yjprji4g3deubw@adacore.com> (Joel Brobecker's message of "Mon, 7 May 2018 10:13:09 -0700") Message-ID: <8736yp4xo8.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00393.txt.bz2 On Monday, May 07 2018, Joel Brobecker wrote: > I was wondering if anyone had any thoughts regarding Tom patch. > https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html > > Below are my comments on it, and also my interrogations on whether > we might want this patch in 8.1.1 or not. > > Additional thoughts: > - This is a regression > - This is an internal error, so it can be fairly problematic > - It only happens with -readnow, it seems, which I assume > is not widely used considering the performance and memory > cost of this feature. > > I might tip in favor of putting it in, considering the fact that > I don't think there is much of a workaround, but I would not make > that call just on my own, because the patch is far from obvious. [ CCing Pedro. ] Hey Joel, Just my two cents here. This patch apparently fixes a bunch of bugs filed against Fedora GDB, which may indicate that either (a) it's not related only to -readnow, or (b) more people use -readnow than we know of ;-). In either case, and speaking without much knowledge of the patch itself, I think it should be included in 8.1.1. At least I know I will include it in our Fedora GDB (and well, if Tom is willing to backport it, then he'll also save me some time!). Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/