From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122708 invoked by alias); 22 May 2018 13:58:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122482 invoked by uid 89); 22 May 2018 13:58:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=reviews X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 May 2018 13:58:14 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4MDtLPX064936 for ; Tue, 22 May 2018 09:58:13 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j4kyyt3s4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 May 2018 09:58:12 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2018 07:58:12 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 22 May 2018 07:58:11 -0600 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4MDw9BB12189976; Tue, 22 May 2018 06:58:09 -0700 Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1E34C6057; Tue, 22 May 2018 07:58:09 -0600 (MDT) Received: from pedro.localdomain (unknown [9.18.235.153]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 6ACB4C6042; Tue, 22 May 2018 07:58:09 -0600 (MDT) Received: by pedro.localdomain (Postfix, from userid 1000) id 003C63C03B6; Tue, 22 May 2018 10:57:58 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files In-Reply-To: <20180522123927.19099D804DB@oc3748833570.ibm.com> References: <20180522123927.19099D804DB@oc3748833570.ibm.com> Date: Tue, 22 May 2018 14:33:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18052213-8235-0000-0000-00000D8BD88C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009065; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000261; SDB=6.01036032; UDB=6.00529967; IPR=6.00815160; MB=3.00021235; MTD=3.00000008; XFM=3.00000015; UTC=2018-05-22 13:58:12 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18052213-8236-0000-0000-000041146888 Message-Id: <8736yjeqs9.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805220162 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00553.txt.bz2 Ulrich Weigand writes: >> I haven't changed this in v2 yet. I did change how an error is checked >> and handled to make it more explicit. > > Yes, that looks fine for now. Ok, I'll commit the patch as it is now (with target_stack used by ppc_linux_nat) and leave the auxv changes for the future. Thank you for the reviews!