From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83452 invoked by alias); 12 Jul 2018 05:03:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83428 invoked by uid 89); 12 Jul 2018 05:03:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.161) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jul 2018 05:03:06 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id CFA6692CE for ; Thu, 12 Jul 2018 00:03:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dTkafadhAaSeydTkmfDh4J; Thu, 12 Jul 2018 00:03:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MYyx5q7j8vm2a2Ig05Ik+Olryuy40cOPRYIULZnhp9E=; b=w8fMadYwxa4vDHYWMLt4jFu1/E MCmvpbi2/ZHXur8ryBdy+nomR1+R7R2p7mTBZenicoP8flUY5Dhm+HokcJnYmvm9UDQbktRBDZy4O gezSLbToDGBq8saE1a6i1o5qp; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:57170 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fdTkZ-003C0U-70; Thu, 12 Jul 2018 00:02:43 -0500 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA 24/42] Move pending_blocks and pending_block_obstack to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-25-tom@tromey.com> <8fb1dcaa-41ad-8ade-aab2-f1890fec6865@simark.ca> <87fu0pcbjr.fsf@tromey.com> Date: Thu, 12 Jul 2018 05:03:00 -0000 In-Reply-To: <87fu0pcbjr.fsf@tromey.com> (Tom Tromey's message of "Wed, 11 Jul 2018 22:39:36 -0600") Message-ID: <8736wpcah9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00334.txt.bz2 >>>>> "Tom" == Tom Tromey writes: >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >>> @@ -344,7 +348,6 @@ find_symbol_in_list (struct pending *list, char *name, int length) >>> >>> scoped_free_pendings::scoped_free_pendings () >>> { >>> - gdb_assert (pending_blocks == nullptr); >>> } Simon> You can remove the constructor (here and in the .h). Tom> I made this change. Actually I had to "= default" the constructor, due to the use of DISABLE_COPY_AND_ASSIGN. Tom