From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7331 invoked by alias); 11 Aug 2018 14:49:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7310 invoked by uid 89); 11 Aug 2018 14:49:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Aug 2018 14:49:46 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 8DA34E57D3 for ; Sat, 11 Aug 2018 09:49:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oVD7fQCUmBcCXoVD7fzEfc; Sat, 11 Aug 2018 09:49:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JycASwOKlmjcLQIOEEdA1mAl3K4rPniU3lzJnLDSn48=; b=N20z/nfhbc0e0Xq7X6+jdnxsTB M70njmfmGKLY0aumF6nbk+1ieI3WpUBeesUVc3ygkyLHcv5+SCNSToQyymA/gYqjqAmu4s+APV622 9O2goxuG4jvbuUg6LvOUY/s41; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:57108 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1foVD7-003aD4-8n; Sat, 11 Aug 2018 09:49:45 -0500 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/9] Change `function_symbols' to std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-3-keiths@redhat.com> Date: Sat, 11 Aug 2018 14:49:00 -0000 In-Reply-To: <20180810232534.481-3-keiths@redhat.com> (Keith Seitz's message of "Fri, 10 Aug 2018 16:25:27 -0700") Message-ID: <8736vlufef.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00317.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> This patch changes the `function_symbols' members in linespec.c structures Keith> from a VEC to a std::vector. Keith> gdb/ChangeLog: Keith> * linespec.c (struct linespec) : Change type to Keith> std::vector. Update all users. Keith> (struct collect_info) : Likewise. Keith> (find_method, find_function_symbols, find_linespec_symbols) Keith> (find_label_symbols_in_block): Change `symbols' parameter to Keith> std::vector. Update all callers. Keith> (find_label_symbols): Likewise for `function_symbols' and Keith> `label_funcs_ret'. Thank you for the patch. This one looks ok to me. Tom